Link Contribute

[HarikumarG]

@mansona
Thanks ,
I somewhat understood what you are expecting ..I tried the code which you mentioned...
<EsFooter @contributeLink="https://github.com/ember-learn/ember-website" /> adding this in the files which you said..but i face some error that footer itself is not displaying ..i couldn't get the flow what you are expecting..So I saw those links which are passed as an parameter to <EsFooterStatement/> and done the same think for contribution link also..
If <EsFooter/> tag is used, then again another footer will be added to the existing footer...
If this is not what you are expecting..then let me know...anyways i am about to go through the learn docs once again and i will get it..
Thanks for the guidance..

[mansona]

Thanks for sticking with this 🎉 I think we're almost there, I think the last thing that we need to change is the fact that it's not supposed to have a default value 👍 once we get that solved from the functional perspective we can discuss the design of it 🎉

[HarikumarG]

@mansona
Again Thanks,
Understood your idea that you don't want to be default link that should exist in all the pages which uses <EsFooter> ...You want this link to be added to ember website alone...I removed all those things which you mentioned as not needed..

[mansona]

Almost there! I don't think I explained myself correctly last time. This should only work if the contribution link is being passed into <EsFooter />. I have made suggestions that should implement the functionality that I'm talking about 👍

Can you also add an example of this working in the documentation, please? The file to change should be /docs/components/footer.md

[HarikumarG]

Almost there! I don't think I explained myself correctly last time. This should only work if the contribution link is being passed into <EsFooter />. I have made suggestions that should implement the functionality that I'm talking about

Can you also add an example of this working in the documentation, please? The file to change should be /docs/components/footer.md

@mansona
Thanks,
I have done the changes which you asked ...Let me know after you checked this PR...If it is fine then i can change this footer.md file...What is that required in that document ? Can you please explain me that ? <EsFooter @contributeLink="https://github.com/ember-learn/ember-website" /> is this is enough in that document ?

[mansona]

@HarikumarG yes that's correct. that is all you would need to document, and maybe put a bit of text saying "you can add a link to contribute to this page with the following example: " or something like that 👍

[HarikumarG]

@mansona
Thanks for the guidance..I have updated the footer.md file ...
Now after merging this ...In that ember website we need to pass that URL in that <EsFooter> tag to display that URL ...am i right ?