Enable prettier for links file #377
Conversation
There was a problem hiding this comment.
I know you say to review this commit by commit but can we please keep the prettier and the actual link changes in different PRs to make sure that we don't miss things.
For example, this PR adds a regression where the /release/ part of the Guides link is being removed 👍
|
also I'm surprised by the "remove the copy in the website" because this should never have been added to the website in the first place 🤔 I can't find the PR where it was added, do you have the link? |
| { | ||
| href: 'https://guides.emberjs.com/release/', | ||
| name: 'Ember.js Guides', | ||
| type: 'link', | ||
| }, | ||
| { | ||
| href: 'https://api.emberjs.com', | ||
| name: 'API Reference', | ||
| type: 'link', | ||
| }, | ||
| { | ||
| href: 'https://cli.emberjs.com', | ||
| name: 'CLI Guides', | ||
| type: 'link', | ||
| }, |
There was a problem hiding this comment.
https://guides.emberjs.com is redirected to https://guides.emberjs.com/release and matches the pattern for API and CLI Guides below. The API and CLI links are redirected to the corresponding release pages. I don't think it's good to have a mix of patterns.
|
We discussed this PR at the meeting today and we are merging the formatting changes so we can proceed with updating the actual links :) |
Description
this enables prettier for the links file so that we can follow up and change some links in another PR