Added support for MQTT retain and rewritten in-memory storage #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Florimond
pushed a commit
that referenced
this pull request
Sep 7, 2023
This PR adds support for MQTT Retain flag. In order to make retained messages play well with emitter's message history, we consider that the retained messages are just messages with a large TTL (defaults to `30 days` ). The `retain` TTL is configurable in the storage provider, so you can setup a longer or shorter time. 1. The retain flag will only work if the key has `store` permission 2. The subscriptions with `load` permission will default to `last=1` . This is done in order to be compliant with the MQTT spec as the retain message should always be sent to the subscriptions. Now, you can still have `ttl` and `last` options and it should play well with the retained messages, sending everything.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for MQTT Retain flag. In order to make retained messages play well with emitter's message history, we consider that the retained messages are just messages with a large TTL (defaults to
30 days). TheretainTTL is configurable in the storage provider, so you can setup a longer or shorter time.storepermissionloadpermission will default tolast=1. This is done in order to be compliant with the MQTT spec as the retain message should always be sent to the subscriptions.Now, you can still have
ttlandlastoptions and it should play well with the retained messages, sending everything.