feat: made write rate configurable #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Florimond
pushed a commit
that referenced
this pull request
Sep 7, 2023
This makes the write rate configurable by adding writeRate to the limit configuration. Write rate allows to rate-limit the underlying socket flushes and greatly (15-20x from our benchmarks) increases the througput of emitter broker. The value is set to a reasonnable 60 write/s per connection. Keep in mind this is not limiting the QpS but merely limiting the amount of syscalls going out to the OS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the write rate configurable by adding
writeRateto thelimitconfiguration. Write rate allows to rate-limit the underlying socket flushes and greatly (15-20x from our benchmarks) increases the througput of emitter broker. The value is set to a reasonnable 60 write/s per connection. Keep in mind this is not limiting the QpS but merely limiting the amount of syscalls going out to the OS.