Skip to content

Commit

Permalink
Renaming the virtual device Nexus5 name to Nexus5.gce_x86 (#145225)
Browse files Browse the repository at this point in the history
This is required to match a rename being made for the devices in firebase lab.

Also removed `version=24` entry, since thats not supported on Nexus5x, per the firebase team.

Bug:b/322830672

*Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.*

*List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.*

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
  • Loading branch information
yusuf-goog authored Mar 15, 2024
1 parent 71606af commit 1c153c3
Showing 1 changed file with 9 additions and 10 deletions.
19 changes: 9 additions & 10 deletions .ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -523,10 +523,9 @@ targets:
# "--device", "model=Nexus6P,version=25"
virtual_devices: >-
[
"--device", "model=Nexus5,version=21",
"--device", "model=Nexus5,version=22",
"--device", "model=Nexus5,version=23",
"--device", "model=Nexus5,version=24",
"--device", "model=Nexus5.gce_x86,version=21",
"--device", "model=Nexus5.gce_x86,version=22",
"--device", "model=Nexus5.gce_x86,version=23",
"--device", "model=Nexus6P,version=25",
"--device", "model=Nexus6P,version=26",
"--device", "model=Nexus6P,version=27",
Expand Down Expand Up @@ -555,9 +554,9 @@ targets:
# "--device", "model=Nexus6P,version=25"
virtual_devices: >-
[
"--device", "model=Nexus5,version=21",
"--device", "model=Nexus5,version=22",
"--device", "model=Nexus5,version=23",
"--device", "model=Nexus5.gce_x86,version=21",
"--device", "model=Nexus5.gce_x86,version=22",
"--device", "model=Nexus5.gce_x86,version=23",
"--device", "model=Nexus6P,version=25",
"--device", "model=Nexus6P,version=26",
"--device", "model=Nexus6P,version=27",
Expand Down Expand Up @@ -586,9 +585,9 @@ targets:
# "--device", "model=Nexus6P,version=25"
virtual_devices: >-
[
"--device", "model=Nexus5,version=21",
"--device", "model=Nexus5,version=22",
"--device", "model=Nexus5,version=23",
"--device", "model=Nexus5.gce_x86,version=21",
"--device", "model=Nexus5.gce_x86,version=22",
"--device", "model=Nexus5.gce_x86,version=23",
"--device", "model=Nexus6P,version=25",
"--device", "model=Nexus6P,version=26",
"--device", "model=Nexus6P,version=27",
Expand Down

0 comments on commit 1c153c3

Please sign in to comment.