Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add flag for disabling json logging #111

Merged
merged 3 commits into from
May 23, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions src/enochecker/checkerservice.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@

def checker_routes(
checker_cls: Type["BaseChecker"],
disable_json_logging: bool,
) -> Tuple[
Callable[[], Response],
Callable[[], Response],
Expand Down Expand Up @@ -73,7 +74,7 @@ def serve_checker() -> Response:
except jsons.exceptions.UnfulfilledArgumentError as e:
return Response(e._msg, status=400)

checker = checker_cls(task_msg)
checker = checker_cls(task_msg, json_logging=(not disable_json_logging))

checker.logger.info(task_msg)
res = checker.run()
Expand Down Expand Up @@ -169,7 +170,9 @@ def get_service_info() -> Response:
return index, serve_checker, service_info, get_service_info


def init_service(checker: Type["BaseChecker"]) -> Flask:
def init_service(
checker: Type["BaseChecker"], disable_json_logging: bool = False
) -> Flask:
"""
Initialize a flask app that can be used for WSGI or listen directly.

Expand All @@ -179,7 +182,9 @@ def init_service(checker: Type["BaseChecker"]) -> Flask:
:return: a flask app with post and get routes set, ready for checking.
"""
app = Flask(__name__)
index, checker_route, service_info, get_service_info = checker_routes(checker)
index, checker_route, service_info, get_service_info = checker_routes(
checker, disable_json_logging=disable_json_logging
)

app.route("/", methods=["GET"])(index)
app.route("/", methods=["POST"])(checker_route)
Expand Down
15 changes: 13 additions & 2 deletions src/enochecker/enochecker.py
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,12 @@ def parse_args(argv: Optional[Sequence[str]] = None) -> argparse.Namespace:
if argv is None:
return parse_args(sys.argv[1:])
parser = argparse.ArgumentParser(description="Your friendly checker script")
parser.add_argument(
"-j",
"--disable-json-logging",
action="store_true",
help="Disable the JSON (ENOLOGMESSAGE) output",
)

subparsers = parser.add_subparsers(
help="The checker runmode (run/listen)", dest="runmode"
Expand Down Expand Up @@ -853,10 +859,15 @@ def run(
"""
parsed = parse_args(args)
if parsed.runmode == "listen":
checker_cls.service.run(host="::", debug=True, port=parsed.listen_port)
flask_app = init_service(
checker_cls, disable_json_logging=parsed.disable_json_logging
)
flask_app.run(host="::", debug=True, port=parsed.listen_port)
return None
else:
task_message = task_message_from_namespace(parsed)
result = checker_cls(task_message).run()
result = checker_cls(
task_message, json_logging=(not parsed.disable_json_logging)
).run()
print(f"Checker run resulted in Result: {result.result.name}")
return result