use bson instead of json in StoredDict

[ldruschk]

most notably bytes is not JSON-serializable. Since the NoSQLDict/MongoDB uses bson internally, this way, the behavior of StoredDict and NoSQLDict should be identical. Note that the value must be stored in a dict, since bson does not allow serializing values which are not a mapping type.

[domenukk]

Cool stuff

[ldruschk]

Yeah, that's just how bson.BSON works, it is not the usual decode on bytes On 27 May 2021 22:36:38 CEST, Dominik Maier ***@***.***> wrote: ***@***.*** commented on this pull request.

…

> @@ -272,9 +273,9 @@ def __getitem__(self, key: str) -> Any: if not locked: self.lock(key) try: - with open(self._dir_jsonname(key), "rb") as f: - val = json.loads(f.read().decode("utf-8")) - except (OSError, json.decoder.JSONDecodeError) as ex: + with open(self._dir_bsonname(key), "rb") as f: + val = bson.BSON(f.read()).decode()["value"] Ah I guess that's just how this works? -- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: #120 (comment)