Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve dimensional testing of equations and substitution. #73

Merged
merged 18 commits into from
Jun 4, 2019
Merged

Improve dimensional testing of equations and substitution. #73

merged 18 commits into from
Jun 4, 2019

Conversation

schymans
Copy link
Collaborator

This should solve #57 by using a modified Quantity._collect_factor_and_dimension from sympy instead of the original dimension checking. It also allows substitution of several equations into one, using eq1.subs(eq2, eq3, eq4).

schymans and others added 18 commits April 8, 2019 18:12
@schymans
Copy link
Collaborator Author

I just fixed another problem: in markdown() there was a line to change the printing of quantities and only display their abbreviations. This led to problems when working with units, so I removed that statement and instead extract the abbreviations directly in markdown().

@jirikuncar
Copy link
Collaborator

@schymans do you want to squash the commits?

@schymans schymans merged commit f0b4422 into environmentalscience:master Jun 4, 2019
@schymans schymans deleted the derived_units branch June 4, 2019 15:10
@schymans schymans mentioned this pull request Jul 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jirikuncar jirikuncar jirikuncar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@schymans @jirikuncar