Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check dimensions #94

Merged
merged 7 commits into from
Oct 27, 2020
Merged

Conversation

schymans
Copy link
Collaborator

@schymans schymans commented Oct 20, 2020

Avoids dimensional error with dimensionless variables in functions, e.g. exp(Dimension(1)).
Closes #82
Closes #93

essm/variables/_core.py Outdated Show resolved Hide resolved
essm/variables/_core.py Outdated Show resolved Hide resolved
schymans and others added 2 commits October 23, 2020 14:44
Co-authored-by: Jiri Kuncar <jiri.kuncar@gmail.com>
Co-authored-by: Jiri Kuncar <jiri.kuncar@gmail.com>
@schymans schymans merged commit 34fca08 into environmentalscience:master Oct 27, 2020
@schymans schymans deleted the check_dimensions branch October 27, 2020 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dimensional consistency test fails for exp() Dimensional consistency test fails for 1/cos(var1)
2 participants