Add supplementary_imports and test #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jirikuncar
reviewed
Dec 18, 2020
| Features | ||
| ~~~~~~~~ | ||
|
|
||
| - **utils:** Enable supplementary_imports in VariableWriter and EquationWriter |
There was a problem hiding this comment.
Suggested change
| - **utils:** Enable supplementary_imports in VariableWriter and EquationWriter | |
| - **utils:** Enable `supplementary_imports` in `VariableWriter` and `EquationWriter` |
jirikuncar
approved these changes
Dec 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using EquationWriter and VariableWriter to create .py files, re-import of those files fails if variables or equations use functions that are not in the standard imports. Therefore, I created a new input option for both functions,
supplementary_imports, which takes a dictionary with additional imports to be embedded in the .py files. I updated the docstrings to provide examples and also a new test in test_equations.py.