Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot test CDX export with certain files #1015

Closed
even1024 opened this issue Jan 31, 2023 · 0 comments · Fixed by #1021
Closed

Cannot test CDX export with certain files #1015

even1024 opened this issue Jan 31, 2023 · 0 comments · Fixed by #1021
Assignees
@even1024
Labels
Bug
Milestone
Indigo-1.11.0-rc.1

Comments

@even1024
Copy link
Collaborator

even1024 commented Jan 31, 2023 •
edited by vanoprenko
Loading

Generated cdx files are not equal under different platforms

Steps to Reproduce

  1. Convert Indigo\api\tests\integration\tests\formats\cdxml to cdx files on multiple platforms: mac os x, ubuntu, iron python.
  2. Compare generated files

Expected behavior
CDX-files should be binary identical

Actual behavior
Files has the same values for given keys, but the key ordering is different so the files are not binary-identical.
@even1024 even1024 added the Bug label Jan 31, 2023
@even1024 even1024 added this to the Indigo-1.11.0-rc.1 milestone Jan 31, 2023
@even1024 even1024 self-assigned this Jan 31, 2023
@vanoprenko vanoprenko changed the title Generated cdx files are not equal under different platforms Cannot test CDX export with certain files Jan 31, 2023
@even1024 even1024 linked a pull request Feb 3, 2023 that will close this issue
#1015 Cannot test CDX export with certain files #1021
Merged
@even1024 even1024 closed this as completed Feb 3, 2023
AlexanderSavelyev pushed a commit that referenced this issue Feb 20, 2023
@even1024
#1015 Cannot test CDX export with certain files (#1021)
d895645 
* cdxml test

* cdxml test

* uninitialized values

* uninitialized values

* update test

* clang fix

* test fix

* test fix

* test fix

* test fix

* test fix

* test fix

* check locale

* test fix

* test fix

* cdx test fix

* clang fix

* test fix

* test fix

* test fix

---------

Co-authored-by: Roman Porozhnetov <roman_porozhnetov@epam.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@even1024 even1024

Labels
Bug
Projects
None yet
Milestone
Indigo-1.11.0-rc.1
Development

Successfully merging a pull request may close this issue.

#1015 Cannot test CDX export with certain files epam/Indigo
1 participant
@even1024