Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't open mol v3000 files with 'S-Group Properties Type = Generic' and 'S-Group Properties Type = Multiple' #1084

Closed
Zhirnoff opened this issue Mar 27, 2023 · 0 comments
Closed

Can't open mol v3000 files with 'S-Group Properties Type = Generic' and 'S-Group Properties Type = Multiple' #1084

Zhirnoff opened this issue Mar 27, 2023 · 0 comments
Assignees
@Wadym
Labels
Bug regression
Milestone
Indigo-1.11.0-rc.1

Comments

@Zhirnoff
Copy link
Collaborator

Scenario 1

  1. Launch Ketcher
  2. Open mol v3000 file with S-Group Properties Type = Generic SgroupDifferent.zip

Actual behavior
Error message: Convert error! IndigoException: pool: access to unused element 28
2023-03-17_15h00_53

Expected behavior
File opens without error. With all added S-Group Properties

Scenario 2

  1. Launch Ketcher
  2. Open mol v3000 file with S-Group Properties Type = Multiple group Multi_V3000.zip

Actual behavior
Error message: Convert error! IndigoException: pool: access to unused element 33
2023-03-27_16h56_55
Expected behavior
File opens without error. With all added S-Group Properties

Note: This is due to the fact that S-Group Properties Type = Generic was removed in version 2.9.0. And now Ketcher opens files that were saved with 'S-Group Properties Type = Generic' for mol v2000 with a warning about importing without this group, and for mol v3000 files with an error.

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser Chrome
  • Version 109.0.5414.120 (Official Build) (64-bit)

Indigo/Bingo version
Indigo Toolkit
Version 1.10.0.0-ga65114f36-x86_64-linux-gnu-11.2.1

Related Ketcher issue:
epam/ketcher#2387

Test case
EPMLSOPKET-1875
EPMLSOPKET-1895
@Zhirnoff Zhirnoff added this to the Indigo-1.11.0-rc.1 milestone Mar 27, 2023
@Zhirnoff Zhirnoff mentioned this issue Mar 27, 2023
Open
Wadym added a commit that referenced this issue Mar 31, 2023
@Wadym
Can't open mol v3000 files with 'S-Group Properties Type = Generic' a…
05b6877 
…nd 'S-Group Properties Type = Multiple' #1084
@Wadym Wadym mentioned this issue Mar 31, 2023
Merged
even1024 pushed a commit that referenced this issue Apr 2, 2023
@Wadym
Can't open mol v3000 files with 'S-Group Properties Type = Generic' a… (
05e93af 
#1090)

* Can't open mol v3000 files with 'S-Group Properties Type = Generic' and 'S-Group Properties Type = Multiple' #1084

* fixes formatting

* fixes formatting

* fixes tests
@even1024 even1024 closed this as completed Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Wadym Wadym

Labels
Bug regression
Projects
None yet
Milestone
Indigo-1.11.0-rc.1
Development

No branches or pull requests
3 participants
@even1024 @Wadym @Zhirnoff