Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Label for unknown monomer is wrong #2060

Closed
AlexeyGirin opened this issue Jul 3, 2024 · 1 comment · Fixed by #2083 or #2082
Closed

Label for unknown monomer is wrong #2060

AlexeyGirin opened this issue Jul 3, 2024 · 1 comment · Fixed by #2083 or #2082
Assignees
@AliaksandrDziarkach
Labels
Bug IDT Priority: High
Milestone
Indigo-1.22.0-rc.2

Comments

@AlexeyGirin
Copy link
Collaborator

Steps to Reproduce

  1. Go to Macromolecules mode - Flex mode
  2. Load using paste from clipboard IDT type: /5i2AmPr/
    image

Actual behavior
System adds monomer to the canvas with label: unknown_monomer_with_idt_alias_i2AmPr
image

Expected behavior
System adds monomer to the canvas with label: i2AmPr
image

As per requirements:

1. Display on canvas:
    - in flex/snake modes - as a "black box" (see mockups)

image

Versions

  • Ketcher Version 2.22.0-rc.2 Build at 2024-06-28; 05:30:15
  • Indigo Toolkit Version 1.22.0-dev.2.1-gd5637f75-wasm32-wasm-clang-12.0.0
  • Windows 10 Pro
  • Chrome Version 126.0.6478.127 (Official Build) (64-bit)

Issue found while testing - epam/ketcher#4431
@AlexeyGirin AlexeyGirin added this to the Indigo-1.22.0-rc.2 milestone Jul 3, 2024
@AlexeyGirin AlexeyGirin mentioned this issue Jul 3, 2024
Closed
@AliaksandrDziarkach AliaksandrDziarkach self-assigned this Jul 4, 2024
AliaksandrDziarkach added a commit that referenced this issue Jul 4, 2024
@AliaksandrDziarkach
#2060 Label for unknown monomer is wrong
937abd5 
Fix labels. Update UT.
AliaksandrDziarkach added a commit that referenced this issue Jul 4, 2024
@AliaksandrDziarkach
Backmerge: #2060 Label for unknown monomer is wrong
28a7817 
Backmerge to master
This was linked to pull requests Jul 4, 2024
Backmerge: #2060 Label for unknown monomer is wrong #2083
Merged
#2060 Label for unknown monomer is wrong #2082
Merged
@AliaksandrDziarkach AliaksandrDziarkach mentioned this issue Jul 4, 2024
Closed
AliaksandrDziarkach added a commit that referenced this issue Jul 4, 2024
@AliaksandrDziarkach
#2060 Label for unknown monomer is wrong (#2082)
cd379f7
AlexanderSavelyev pushed a commit that referenced this issue Jul 4, 2024
@AliaksandrDziarkach
Backmerge: #2060 Label for unknown monomer is wrong (#2083)
0cdad5f
@Zhirnoff
Copy link
Collaborator

Tested. Bug fixed.
2024-07-11_18h08_25

Desktop:

  • OS: Windows 11
  • Browser Chrome
  • Version 124.0.6367.79 (Official Build) (64-bit)

Ketcher version
[Version 2.23.0-rc.2]
Indigo version
[Version 1.22.0-rc.2]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AliaksandrDziarkach AliaksandrDziarkach

Labels
Bug IDT Priority: High
Projects
None yet
Milestone
Indigo-1.22.0-rc.2
3 participants
@AliaksandrDziarkach @AlexeyGirin @Zhirnoff