Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

System establishes connection between monomers even if data is wrong #2064

Closed
AlexeyGirin opened this issue Jul 3, 2024 · 1 comment · Fixed by #2094 or #2095
Closed

System establishes connection between monomers even if data is wrong #2064

AlexeyGirin opened this issue Jul 3, 2024 · 1 comment · Fixed by #2094 or #2095
Assignees
@AliaksandrDziarkach
Labels
Bug HELM Bucket: Bugs related to Export to HELM format Priority: Medium
Milestone
Indigo-1.22.0-rc.2

Comments

@AlexeyGirin
Copy link
Collaborator

Steps to Reproduce

  1. Go to Macromolecules mode - Flex mode
  2. Load using paste from clipboard IDT type: CHEM1{[A6OH]}|PEPTIDE1{A}$CHEM10,PEPTIDE1,1:R2-1:R1$$$V2.0
    image

Actual behavior
Loads chain without error
image

Expected behavior
Error should occur since CHEM10 monomer is not defined

Versions

  • Ketcher Version 2.23.0-rc.1 Build at 2024-07-02; 08:57:41
  • Indigo Toolkit Version 1.22.0-rc.1.0-g2bef0ce6c-wasm32-wasm-clang-19.0.0
  • Windows 10 Pro
  • Chrome Version 126.0.6478.127 (Official Build) (64-bit)

Issue found while testing - #1188
@AlexeyGirin AlexeyGirin added Bug Priority: Medium HELM Bucket: Bugs related to Export to HELM format labels Jul 3, 2024
@AlexeyGirin AlexeyGirin added this to the Indigo-1.22.0-rc.2 milestone Jul 3, 2024
@AlexeyGirin AlexeyGirin changed the title System establishes connection between monomers even if data is wrong (CHEM1{[A6OH]}|PEPTIDE1{A}$CHEM10,PEPTIDE1,1:R2-1:R1$$$V2.0) System establishes connection between monomers even if data is wrong Jul 3, 2024
@AliaksandrDziarkach AliaksandrDziarkach self-assigned this Jul 5, 2024
AliaksandrDziarkach added a commit that referenced this issue Jul 8, 2024
@AliaksandrDziarkach
#2064 System establishes connection between monomers even if data is…
2c607ee 
… wrong

Add checks. Add UTs.
@AliaksandrDziarkach AliaksandrDziarkach linked a pull request Jul 8, 2024 that will close this issue
#2064 System establishes connection between monomers even if data is wrong #2094
Merged
8 tasks
AliaksandrDziarkach added a commit that referenced this issue Jul 8, 2024
@AliaksandrDziarkach
Backmerge: #2064 System establishes connection between monomers even …
3e187c4 
…if data is wrong

backmerge to master
@AliaksandrDziarkach AliaksandrDziarkach linked a pull request Jul 8, 2024 that will close this issue
Backmerge: #2064 System establishes connection between monomers even if data is wrong #2095
Merged
4 tasks
AlexanderSavelyev pushed a commit that referenced this issue Jul 8, 2024
@AliaksandrDziarkach
#2064 System establishes connection between monomers even if data is…
1d5300c 
… wrong (#2094)
AlexanderSavelyev pushed a commit that referenced this issue Jul 8, 2024
@AliaksandrDziarkach
Backmerge: #2064 System establishes connection between monomers even …
51d5876 
…if data is wrong (#2095)
@AlexeyGirin
Copy link
Collaborator Author

Fixed.
image

  • Ketcher Version 2.23.0-rc.2 Build at 2024-07-10; 19:39:22
  • Indigo Toolkit Version 1.22.0-rc.2.0-ga21fb5d8f-wasm32-wasm-clang-19.0.0
  • Windows 10 Pro
  • Chrome Version 126.0.6478.127 (Official Build) (64-bit)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AliaksandrDziarkach AliaksandrDziarkach

Labels
Bug HELM Bucket: Bugs related to Export to HELM format Priority: Medium
Projects
None yet
Milestone
Indigo-1.22.0-rc.2
2 participants
@AliaksandrDziarkach @AlexeyGirin