Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import of monomer with only one connection point (R2) doesn't work (PEPTIDE1{[DACys]}|PEPTIDE2{C}$PEPTIDE2,PEPTIDE1,1:R2-1:R2$$$V2.0) #2358

Closed
AlexeyGirin opened this issue Sep 11, 2024 · 1 comment · Fixed by #2364 or #2365
Closed

Import of monomer with only one connection point (R2) doesn't work (PEPTIDE1{[DACys]}|PEPTIDE2{C}$PEPTIDE2,PEPTIDE1,1:R2-1:R2$$$V2.0) #2358

AlexeyGirin opened this issue Sep 11, 2024 · 1 comment · Fixed by #2364 or #2365
Assignees
@AliaksandrDziarkach
Labels
Bug HELM Bucket: Bugs related to Export to HELM format Priority: High
Milestone
Indigo-1.24.0-rc.3

Comments

@AlexeyGirin
Copy link
Collaborator

Steps to Reproduce

  1. Toggle to Macro - Flex mode
  2. Load HELM using paste from clipboard way: PEPTIDE1{[DACys]}|PEPTIDE2{C}$PEPTIDE2,PEPTIDE1,1:R2-1:R2$$$V2.0
    image

Actual behavior
System throws exception: Convert error! Given string could not be loaded as (query or plain) molecule or reaction, see the error messages: 'Ket Base Monomer: Unknown attachment point 'R2' in monomer DACys'
image

Expected behavior
System loads sequence successfully
image

Versions

  • Ketcher Version 2.25.0-rc.1 Build at 2024-09-03; 15:31:03
  • Indigo Toolkit Version 1.24.0-rc.1.0-gb8f099851-wasm32-wasm-clang-19.0.0
  • Chrome Version 128.0.6613.114 (Official Build) (64-bit)
  • Win10

Reference issues: #1188
@AlexeyGirin AlexeyGirin added Bug Priority: High HELM Bucket: Bugs related to Export to HELM format labels Sep 11, 2024
@AlexeyGirin AlexeyGirin added this to the Indigo-1.24.0-rc.3 milestone Sep 11, 2024
@AliaksandrDziarkach AliaksandrDziarkach self-assigned this Sep 12, 2024
AliaksandrDziarkach added a commit that referenced this issue Sep 12, 2024
@AliaksandrDziarkach
#2358 Import of monomer with only one connection point (R2) doesn't …
d546f67 
…work

Fix AP parse. Add UTs.
@AliaksandrDziarkach AliaksandrDziarkach linked a pull request Sep 12, 2024 that will close this issue
#2358 - Import of monomer with only one connection point (R2) doesn't work #2362
Closed
8 tasks
AliaksandrDziarkach pushed a commit that referenced this issue Sep 12, 2024
@AlexanderSavelyev @AliaksandrDziarkach
Backmerge: #2358 - Import of monomer with only one connection point (…
3db92f6 
…R2) doesn't work

backmerge to master
@AliaksandrDziarkach AliaksandrDziarkach linked a pull request Sep 12, 2024 that will close this issue
Backmerge: #2358 - Import of monomer with only one connection point (R2) doesn't work #2363
Closed
4 tasks
AliaksandrDziarkach added a commit that referenced this issue Sep 12, 2024
@AliaksandrDziarkach
#2358 - Import of monomer with only one connection point (R2) doesn'…
f8464c4 
…t work

Fix AP parse. Add UTs.
@AliaksandrDziarkach AliaksandrDziarkach linked a pull request Sep 12, 2024 that will close this issue
#2358 - Import of monomer with only one connection point (R2) doesn't work #2364
Merged
8 tasks
This was unlinked from pull requests Sep 12, 2024
#2358 - Import of monomer with only one connection point (R2) doesn't work #2362
Closed
Backmerge: #2358 - Import of monomer with only one connection point (R2) doesn't work #2363
Closed
AliaksandrDziarkach added a commit that referenced this issue Sep 12, 2024
@AliaksandrDziarkach
Backmerge: #2358 - Import of monomer with only one connection point (…
23bb8fd 
…R2) doesn't work

backmerge to master
@AliaksandrDziarkach AliaksandrDziarkach linked a pull request Sep 12, 2024 that will close this issue
Backmerge: #2358 - Import of monomer with only one connection point (R2) doesn't work #2365
Merged
4 tasks
AlexanderSavelyev pushed a commit that referenced this issue Sep 12, 2024
@AliaksandrDziarkach
#2358 - Import of monomer with only one connection point (R2) doesn'…
1c4dcd7 
…t work (#2364)
AlexanderSavelyev pushed a commit that referenced this issue Sep 12, 2024
@AliaksandrDziarkach
Backmerge: #2358 - Import of monomer with only one connection point (…
718293e 
…R2) doesn't work (#2365)
@AlexeyGirin
Copy link
Collaborator Author

Verified.
image
Versions

  • Ketcher Version 2.25.0-rc.3 Build at 2024-09-18; 16:24:03
  • Indigo Toolkit Version 1.24.0-rc.3.0-g692080c62-wasm32-wasm-clang-19.0.0
  • Chrome Version 129.0.6668.59 (Official Build) (64-bit)
  • Win10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AliaksandrDziarkach AliaksandrDziarkach

Labels
Bug HELM Bucket: Bugs related to Export to HELM format Priority: High
Projects
None yet
Milestone
Indigo-1.24.0-rc.3
2 participants
@AliaksandrDziarkach @AlexeyGirin