Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1878 - The structure saved in CML format does not open #1947

Merged
merged 13 commits into from
May 17, 2024
Merged

#1878 - The structure saved in CML format does not open #1947

merged 13 commits into from
May 17, 2024

Conversation

NayanaGadakh
Copy link
Collaborator

Generic request

  • The structure saved in CML format does not open #1878
  • [✓] branch name does not contain '#'
  • [✓] base branch (master or release/xx) is correct
  • [✓] PR is linked with the issue
  • [✓] task status changed to "Code review"
  • [✓] code follows product standards
  • [✓] regression tests updated

@NayanaGadakh NayanaGadakh linked an issue May 13, 2024 that may be closed by this pull request
The structure saved in CML format does not open #1878
Closed
@NayanaGadakh NayanaGadakh self-assigned this May 13, 2024
@NayanaGadakh NayanaGadakh changed the title Added virtual atom to make trigonal structure as tetrahedral. #1878 - Added virtual atom to make trigonal structure as tetrahedral. May 15, 2024
@NayanaGadakh NayanaGadakh changed the title #1878 - Added virtual atom to make trigonal structure as tetrahedral. #1878 - The structure saved in CML format does not open May 16, 2024
even1024
even1024 approved these changes May 17, 2024
View reviewed changes
Copy link
Collaborator

@even1024 even1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything is ok

@even1024 even1024 merged commit 3cd0c5d into master May 17, 2024
74 checks passed
@even1024 even1024 deleted the 1878-the-structure-saved-in-cml-format-does-not-open branch May 17, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@even1024 even1024 even1024 approved these changes

Assignees

@NayanaGadakh NayanaGadakh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The structure saved in CML format does not open
2 participants
@NayanaGadakh @even1024