Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#808: render2d: equilibrium arrows rendering supported #801

Merged
merged 3 commits into from
Aug 7, 2022

Conversation

even1024
Copy link
Collaborator

No description provided.

@even1024 even1024 marked this pull request as ready for review July 29, 2022 22:24
@mkviatkovskii mkviatkovskii assigned even1024 and unassigned even1024 Aug 3, 2022
@even1024 even1024 changed the title all equilibriums all equilibriums #808 Aug 3, 2022
@mkviatkovskii
Copy link
Member

@even1024 please rename the pull request so it's clear to understand what parts of the code changed and for what reasons. Like:

#808: render2d: equilibrium arrows rendering supported

@mkviatkovskii mkviatkovskii self-requested a review August 7, 2022 07:01
@even1024 even1024 changed the title all equilibriums #808 feature/808: render2d: equilibrium arrows rendering supported Aug 7, 2022
@even1024 even1024 added this to the indigo-1.8 milestone Aug 7, 2022
@even1024
Copy link
Collaborator Author

even1024 commented Aug 7, 2022

@even1024 please rename the pull request so it's clear to understand what parts of the code changed and for what reasons. Like:

#808: render2d: equilibrium arrows rendering supported

Fixed

@mkviatkovskii mkviatkovskii changed the title feature/808: render2d: equilibrium arrows rendering supported #808: render2d: equilibrium arrows rendering supported Aug 7, 2022
@mkviatkovskii
Copy link
Member

@even1024 please rename the pull request so it's clear to understand what parts of the code changed and for what reasons. Like:

#808: render2d: equilibrium arrows rendering supported

Fixed

Not exactly, we don't need feature prefix, but need #, because it's used by GitHub to find issue references and mark them

@mkviatkovskii mkviatkovskii merged commit 2cceed3 into master Aug 7, 2022
@mkviatkovskii mkviatkovskii deleted the feature/equillibriums branch August 7, 2022 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants