Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for stereo CIP values in ket format #225

Closed
AlexanderSavelyev opened this issue Dec 28, 2020 · 2 comments · Fixed by #2291, #2479 or #2501
Closed

Add support for stereo CIP values in ket format #225

AlexanderSavelyev opened this issue Dec 28, 2020 · 2 comments · Fixed by #2291, #2479 or #2501
Assignees
@Nitvex
Labels
enhancement epic: internal format
Milestone
Ketcher 2.10.0-rc.1

Comments

@AlexanderSavelyev
Copy link
Contributor

AlexanderSavelyev commented Dec 28, 2020 •
edited
Loading

Background
Internal ketcher format should contain information about CIP calculated values. The current model with S-groups should be replaced by the internal format

Acceptance criteria

  • Don't show tooltip for CIP values
  • CIP data must be moved from s-group properties to atom properties
  • Ketcher must still show CIP labels
  • Available CIP labels: bonds: [E,Z,M,P] atoms: [R,S,r,s]
@AlexanderSavelyev
Copy link
Contributor Author

related to epam/Indigo#310

@AndreiMazol AndreiMazol modified the milestones: Ketcher API, Internal Format Feb 1, 2021
@AndreiMazol AndreiMazol modified the milestones: Internal Format, Release 2.3.0 Apr 21, 2021
@AndreiMazol AndreiMazol mentioned this issue May 31, 2021
Open
@Zhirnoff Zhirnoff mentioned this issue Feb 23, 2023
Closed
@vanoprenko
Copy link
Collaborator

Indigo version should be updated in scope of this task

@KonstantinEpam23 KonstantinEpam23 mentioned this issue Mar 1, 2023
Open
@Nitvex Nitvex linked a pull request Mar 9, 2023 that will close this issue
#225 Add support for stereo CIP values in ket format #2291
Merged
@Nitvex Nitvex closed this as completed Mar 9, 2023
@Nitvex Nitvex reopened this Mar 9, 2023
@Nitvex Nitvex assigned Nitvex and unassigned AndreiMazol Mar 10, 2023
@Zhirnoff Zhirnoff mentioned this issue Mar 10, 2023
Closed
Nitvex added a commit that referenced this issue Apr 12, 2023
@Nitvex
#225 – moved CIP rendering logic to Atom class
c608227
Nitvex added a commit that referenced this issue Apr 12, 2023
@Nitvex
#225 – moved CIP rendering logic to Bond class
c9e4926
Nitvex added a commit that referenced this issue Apr 12, 2023
@Nitvex
#225 – fixed selection for bonds and atoms
3876bd0
Nitvex added a commit that referenced this issue Apr 12, 2023
@Nitvex
#225 – fixed unselect for bonds and atoms
376182d
Nitvex added a commit that referenced this issue Apr 12, 2023
@Nitvex
#225 – removed previous crutch solution
ac95fab
@Nitvex Nitvex mentioned this issue Apr 13, 2023
Merged
Nitvex added a commit that referenced this issue Apr 19, 2023
@Nitvex
#225 – updated possible CIP values for bonds
2bb7b72
Nitvex added a commit that referenced this issue Apr 20, 2023
@Nitvex
#225 add support for stereo cip values in ket format (#2479)
77e13a0 
* #225 – moved CIP rendering logic to Atom class

* #225 – moved CIP rendering logic to Bond class

* #225 – fixed selection for bonds and atoms

* #225 – fixed unselect for bonds and atoms

* #225 – removed previous crutch solution

* #225 – updated possible CIP values for bonds
Nitvex added a commit that referenced this issue Apr 20, 2023
@Nitvex
#225 – Add support for stereo CIP values in ket format
1513222
@Nitvex Nitvex mentioned this issue Apr 20, 2023
Merged
Nitvex added a commit that referenced this issue Apr 20, 2023
@Nitvex
#225 – Add support for stereo CIP values in ket format (#2501)
6b9800b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Nitvex Nitvex

Labels
enhancement epic: internal format
Projects
None yet
Milestone
Ketcher 2.10.0-rc.1
5 participants
@AlexanderSavelyev @vanoprenko @Nitvex @AndreiMazol @KonstantinEpam23