-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crashing during Scan #496
Comments
@Bigmack3000 there is a logic error somewhere in lms, this is an issue that must be fixed. Line 14 in 4cb6689
Showing the last queries would help too (see Line 16 in 4cb6689
Can you remember what triggered this crash? |
Hey, I just installed this on my synology today. This was during my first scan. It was a large libary, over 200k songs, so I don't know if that was part of the issue. I've included the logs here. If there's a specific way to get debugging logs, I can scan it again to get those as well. |
Thanks! I am not sure debug logs would help, I think showing queries is the way to go. |
any ideas on how i get to those files on a synology? |
I've been talking to synology help for a bit now. I'm sorry, I cannot figure out on my own how to access these files. And they couldn't find that directory either. |
Ok I will make a test image for you, but you will have to wait for a week. I will keep you updated! |
ok great. Thanks! |
i followed the steps here: to properly set up a restricted user for docker containers. I'm still having the same error pop up when scanning my library. |
Don't worry, I will craft you a docker image soon. Do you know the arch of your nas? (What is the model?) |
the nas is a DS1618+. Synology says the package arch is Denverton. |
Can you please test with epoupon/lms:7befa739 and paste the output? |
Hey I'm getting the same error messages. I'm trying to post the logs here, but it's over the size limit. One scan created a log that's 600+pages. the previous logs were just a few pages. |
i zipped the file and included it here. |
Thanks! |
Ok. the error hit again on that one. attached is an excerpt from the log. |
that fixed it! thank you! |
ok, so all of the songs are scanning now. My next question would be, why are a lot of albums missing artwork if I know they have it? |
Are the image embedded into audio files? Is there an external cover image? |
That seems to be it. Every file has an album cover embedded in it through picard. But the database is shared with emby, which seperetly downloaded pictures and stored them in the album folders for most albums. LMS seems to be defaulting to the downloaded pictures and then ignoring the embedded ones. Because a lot of albums are displaying a "back of cd" photo instead of the cover. Is there a away to have lms only read embedded covers? |
Lms reads both embedded and external covers. |
files sent. Thanks! |
Ok, thanks. I'll update my picard. What should be used to separate tags? Getting images out of aiff files would be great, like emby. Also having embedded images as the default. Were you able to look at the other files i had attached? About multi artists bot showing up under songs in symfonium? Thanks! |
So, when the files are loaded into symfonium through emby, the multi artist tags are displayed properly, like this: But when they're loaded through LMS, I'm not getting the secondary artists to show up: The files are tagged properly. I'm not sure what setting to change to get it. Also, entire categories, like record labels, come up empty: |
LMS does not support record labels yet. The artist displayed under the songs is the display artist value that LMS returns, if you mix single value and multi value then it gives this. @epoupon can explain how he generate the field |
Oh, I forgot to add the record label, will add this. @Bigmack3000 looks like I don't have the album you show, can you please send it to me so that I can have a look? |
Ok, I've emailed the album over. |
Yes, it solves the split issue, but not the "display artist" issue:
Did you tag with picard? |
yea everything in my library was tagged with picard. Does LMS read the "artists" tag as well for display? |
No since it expects it to be a multi-valued tag, containing all track artists, but with no join strings |
But I still wonder why I don't get the same tags as you. I don't find any relevant option in picard to get the same result as you |
There's a plugin for picard that puts feat artists in the track title. But the song title itself should have no effect on the artists being displayed underneath, right? The artists tag itself is tagged properly, no? It has the track artist and the featured artists all listed, and they match the order of the mbid artist tags. I think if LMS just displayed the artists tag it would fix the problem |
Ah, maybe this plugin also keeps a single artist in the Anyway, it would fix the display artist problem for this plugin, but unfortunately it would break all the other use cases. |
Sorry, I'm getting a little confused. I'm referring to these two tags: I use the plug in because i just like having the feat artists listed in the song title. But the song title should have no affect on anything else. However, if i didn't use the plugin, the artist tag would read "Kendrick Lamar fts. Xyz" and that xyz would change for every artist. Most apps (like emby) would then unfortunately treat every variation as a new artist because the artist tag was different for all of them. The way i do it. "Kendrick Lamarr" is a uniform artist tag. Then the "artists" tag lists kendrick lamarr and everyone featured on the song Then the mbid artist tag lists all the mbids connecting to everyone in the artist tag. Putting every feat artist in the regular "artist" tag ends up breaking a lot of other apps. LMS, i think, is already reading the "artists" tag because if i click more options to a song, I can go to any of the feat artist pages. It would just help immensely if LMS could have the option display the "artists" tag under a song title. So i could see everyone in it without clicking more options. |
If an artist has feat or ft in it, the plugin moves everything after that to the song title so the artist tag is uniform throughout. If its "&" "/" or anything like that, everything stays as is.
It sounds like that would solve the issue. I guess when there's an "artists" tag, the artist tag becomes redundant. But i think it organizes it well. |
Hey, just curious if the "featured artist" part of this was figured out yet? Thanks! |
Hello! |
Discussed in #495
Originally posted by Bigmack3000 July 14, 2024
I don't know if this is the right place to ask, but can someone help with why LMS keeps crashing during scanning? These are the errors that pop up:
terminate called after throwing an instance of 'Wt::Dbo::NoUniqueResultException'
and
what(): Query: resultValue(): more than one result
any ideas? I have the logs, if it would help to post them
The text was updated successfully, but these errors were encountered: