WellLogViewer, Typescript - Wrong type definitions #2259

Anders2303 · 2024-09-23T11:14:20Z

Some of the exported types in the projects are incorrect, compared to what is actually valid for the options (atleast as far as I can see)

In WellLogTypes.ts, discrete objects are typed to an empty array, but it should be Record<string, any[]>

export type WellLogMetadataDiscreteObjects = Record<string, []>;

In WellLogTemplateTypes.ts, both color and type is required, but you'd want to omit them if you're using the style property

export type TemplatePlotProps = {
    type: TemplatePlotTypes;
    // ...
    color: CSSColor;
    // ...
};

The text was updated successfully, but these errors were encountered:

# [1.0.0](https://github.com/equinor/webviz-subsurface-components/compare/wsc-common@0.8.9...wsc-common@1.0.0) (2024-10-03) ### Features * ColorMapFunction type in WellLogView ([#2249](#2249)) ([96bcab4](96bcab4)), closes [#2054](#2054) [#2259](#2259) ### BREAKING CHANGES * - colorMapFunctions array replaces colorTables array to combine color tables and functions in single array - colorMapFunctionName and reverseColorMapFunctionName references replace colorTable and reverseColorTable references (JSON files also should be changed)

hkfb · 2024-10-03T11:23:26Z

🎉 This issue has been resolved in version wsc-common@1.0.0 🎉

The release is available on GitHub release

# [1.0.0](https://github.com/equinor/webviz-subsurface-components/compare/subsurface-viewer@0.30.17...subsurface-viewer@1.0.0) (2024-10-03) ### Features * ColorMapFunction type in WellLogView ([#2249](#2249)) ([96bcab4](96bcab4)), closes [#2054](#2054) [#2259](#2259) ### BREAKING CHANGES * - colorMapFunctions array replaces colorTables array to combine color tables and functions in single array - colorMapFunctionName and reverseColorMapFunctionName references replace colorTable and reverseColorTable references (JSON files also should be changed)

hkfb · 2024-10-03T11:24:11Z

🎉 This issue has been resolved in version subsurface-viewer@1.0.0 🎉

The release is available on GitHub release

# [2.0.0](https://github.com/equinor/webviz-subsurface-components/compare/well-log-viewer@1.13.11...well-log-viewer@2.0.0) (2024-10-03) ### Features * ColorMapFunction type in WellLogView ([#2249](#2249)) ([96bcab4](96bcab4)), closes [#2054](#2054) [#2259](#2259) ### BREAKING CHANGES * - colorMapFunctions array replaces colorTables array to combine color tables and functions in single array - colorMapFunctionName and reverseColorMapFunctionName references replace colorTable and reverseColorTable references (JSON files also should be changed)

hkfb · 2024-10-03T11:24:54Z

🎉 This issue has been resolved in version well-log-viewer@2.0.0 🎉

The release is available on GitHub release

Anders2303 added bug Something isn't working well-log-viewer labels Sep 23, 2024

iWowik mentioned this issue Oct 2, 2024

feat: ColorMapFunction type in WellLogView #2249

Merged

w1nklr closed this as completed in #2249 Oct 3, 2024

w1nklr closed this as completed in 96bcab4 Oct 3, 2024

hkfb added the released label Oct 3, 2024

Provide feedback