Update fuzz targets #697
Merged
Update fuzz targets #697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should make for easier overall reading and also aligns all fuzz targets with the style of `exec.test.cjs`.
Since, per [1], it's not actually guaranteed these work the same. -- 1. nodejs/node#43333
I do not believe these currently provide significant value. They don't seem to test anything special about multiple arguments. Plus the method by which these convert the buffer into multiple args leaves a lot to be desired. An upside is that fuzzing should become more efficient as less cycles are wasted on testing something with little to no value.
ericcornelissen
added
fuzz
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #361, #688
Summary
Update fuzz targets in various ways:
execFileSync,execSync, andspawnSync. (ccdc4b6)