inet_config: Tolerate atoms as inetrc kernel argument
#8902
+9
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many RabbitMQ users provided atoms instead of strings as the `inetrc` file path because of an error in their documentation. This was tolerated by accident until atom filename support was removed from erl_prim_loader. We did the latter for good reason, but tolerating this specifically in inet_config is no big deal.
CT Test ResultsNo tests were run for this PR. This is either because the build failed, or the PR is based on a branch without GH actions tests configured. Results for commit 6d79376 To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts
// Erlang/OTP Github Action Bot |
|
@jhogberg on behalf of the entire RabbitMQ team, thank you for bringing back this really obscure behavior that does not necessarily make much sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many RabbitMQ users provided atoms instead of strings as the
inetrcfile path because of an error in their documentation. This was tolerated by accident until atom filename support was removed fromerl_prim_loader.We did the latter for good reason, but tolerating this specifically in
inet_configis no big deal.Fixes #8899. I figured that simply tolerating it was better than raising an error as it's difficult to present it in a way that makes sense, given how this argument is often provided on the command line.