Fix UDP report issue for 32bits CPUs #1556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidBar-On
changed the title
|
@bmah888, note that the issue fixed by this PR affects all iperf3 3.14 users that run UDP tests on 32 bits machines. |
davidBar-On
changed the title
|
Thanks for the PR! We're working some other stuff at the moment but I'm going to try to get this merged soon-ish. |
bmah888
approved these changes
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version of iperf3 (or development branch, such as
masteror3.1-STABLE) to which this pull request applies:master
Issues fixed (if any):
Output of sender's statistic damaged on Linux i586 #1554
Brief description of code changes (suitable for use as a commit message):
PR Prevent UDP packet count and operations overflow #1536 that changed packet count related variables from
inttoint64_twas not complete for 32 bits CPUs, as there are two cases where 0 is passed as UDP packet count for printing. In 32 bits CPU the 0 is passed as 32 bits instead of 64. This PR fixes the issue (by casting the 0 toint64_t).