Fix numpy_ops gemm output semantics when BLIS is used #521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `out` keyword argument of the `gemm` op specifies an output array. However, the semantics were different depending on whether BLIS is used: * `use_blis==False`: the values of out array are overwritten. * `use_blis==True`: the values of out are added to the result. With this change, the values of `out` are also overwritten with `use_blis=True`.
danieldk
force-pushed
the
blis-gemm-adds-out
branch
from
fb84cc5
to
87fd875
Compare
svlandeg
added
bug
svlandeg
reviewed
Aug 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am reading various parts of the thinc source code to see how things work, I found a small inconsistency in the numpy
gemmop:The
outkeyword argument of thegemmop specifies an output array. However, the semantics were different depending on whether BLIS is used:use_blis==False: the values of out array are overwritten.use_blis==True: the values of out are added to the result.With this change, the values of
outare also overwritten withuse_blis=True.