Fix replace_node on nodes with indirect node refs #537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieldk
force-pushed
the
replace-node-dfs
branch
from
99caf13
to
f99a290
Compare
danieldk
force-pushed
the
replace-node-dfs
branch
from
f99a290
to
6954b30
Compare
Model.replace_node failed if a node n contained a reference to another node m, when m only occurs in one of the (grand)children of n. Since replace_node used the breadth-first Model.walk method, the reference to m would be replaced before m is replaced in the (grand)children of n. However, this fails because set_ref verifies that the a new node reference occurs in the graph. This change resolves this issue by replacing nodes using a depth-first search in post-order. This amounts to doing a topological sort of the transposed graph.
danieldk
force-pushed
the
replace-node-dfs
branch
from
6954b30
to
4e8eaf5
Compare
3 tasks
Update the existing walk method to support both breadth-first and depth-first traversal by adding an `order` argument that supports the following string values: - bfs: breadth-first traversal - dfs_pre: depth-first traversal in pre-order - dfs_post: depth-first traversal in post-order
svlandeg
reviewed
Sep 22, 2021
svlandeg
approved these changes
Sep 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Model.replace_nodefailed if a node n contained a reference to another node m, when m only occurs in one of the (grand)children of n. Sincereplace_nodeused the breadth-firstModel.walkmethod, the reference to m would be replaced before m is replaced in the (grand)children of n. However, this fails becauseset_refverifies that the a new node reference occurs in the graph.This change resolves this issue by replacing nodes using a depth-first search.