Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cache): tiny simplification to walkTree #359

Merged
merged 1 commit into from
Jun 14, 2022

Conversation

agilgur5
Copy link
Collaborator

@agilgur5 agilgur5 commented Jun 12, 2022

Summary

Simplify walkTree by using an expression directly instead of storing it in a variable that is only used once immediately after

Details

  • the acyclic var is literally only used in one place, directly below its instantiation
    • so don't use a var at all instead for simplicity

@agilgur5 agilgur5 added kind: internal Changes only affect the internals, and _not_ the public API or external-facing docs scope: cache Related to the cache labels Jun 12, 2022
- the `acyclic` var is literally only used in one place, directly below its instantiation
  - so don't use a var at all instead for simplicity
@ezolenko ezolenko merged commit 42c94b8 into ezolenko:master Jun 14, 2022
@agilgur5 agilgur5 deleted the refactor-cache-walkTree branch July 2, 2023 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: internal Changes only affect the internals, and _not_ the public API or external-facing docs scope: cache Related to the cache
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants