EZP-25529: Remove uneeded resetting of ezpublish_legacy.kernel alias #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 (was going to try to get travis to run, but unless someone has input on that on the other PR we an take that later) |
|
yes, go ahead :) |
In Symfony 2.7.0 - 2.7.9, this line did nothing, since `ezpublish_legacy.kernel` is an alias and `Container::set` never did anything with aliases. In Symfony 2.7.10, setting an alias to a new value basically converts the alias definition to service definition, meaning that `ezpublish_legacy.kernel` will not point to `ezpublish_legacy.kernel.lazy` any more, thus making the alias invalid next time `ezpublish_legacy.kernel.lazy` is rebuilt. See symfony/symfony#16461 for details
emodric
force-pushed
the
fix_unsetting_legacy_kernel_alias
branch
from
87e971d
to
c5bf6c2
Compare
|
Done! |
|
@andrerom It seems Travis is stuck. Any help? |
|
seems to be running now |
|
Thanks! |
andrerom
added a commit
that referenced
this pull request
Mar 2, 2016
Remove uneeded resetting of ezpublish_legacy.kernel alias
emodric
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.ez.no/browse/EZP-25529
With Symfony 2.7.10, the following error occurs when running legacy scripts through
ezpublish:legacy:scriptwrapper:The fix is quite simple:
In Symfony 2.7.0 - 2.7.9, line removed here did nothing, since
ezpublish_legacy.kernelis an alias and
Container::setnever did anything with aliases.In Symfony 2.7.10, setting an alias to a new value basically converts the
alias definition to service definition, meaning that
ezpublish_legacy.kernelwill not point to
ezpublish_legacy.kernel.lazyany more, thus making the aliasinvalid next time
ezpublish_legacy.kernel.lazyis rebuilt.See symfony/symfony#16461 for details
Manual tests only were performed. Unit tests passed locally.