Fix EZP-25960: Double layout using legacy /layout/set module and LegacyKernelController #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
…cyKernelController > https://jira.ez.no/browse/EZP-25960 When using `/layout/set` legacy module through `LegacyKernelController` having a module layout configured, result from legacy kernel is rendered using this module layout. However, when using `/layout/set`, you already define a layout in legacy stack (via `layout.ini`. Problem is that the result from `/layout/set` will be embedded in the configured module layout, which can give very unexpected results. Best example is that when you want to render XML, JSON or anything not HTML, you'll have the result embedded in some HTML layout.) This patch adds `_ezpublishLegacyLayoutSet` route which corresponds to `/layout/set` module, and ensures that if this route is used through legacy kernel, custom layout won't be used. This fixes the usual behabior of layout module.
lolautruche
force-pushed
the
fix/EZP-25960_LayoutSet
branch
from
30a6f8b
to
7caeb7c
Compare
| @@ -26,3 +26,10 @@ _ezpublishLegacyRest: | |||
| _controller: ezpublish_legacy.rest.controller:restAction | |||
| requirements: | |||
| path: .* | |||
|
|
|||
| _ezpublishLegacyLayoutSet: | |||
| path: /layout/set/{path} | |||
There was a problem hiding this comment.
does this work with uri SA? is that what requirements is about just below?
There was a problem hiding this comment.
does this work with uri SA
Yes, as we override default router to use semanticPathinfo. So this will always work.
The requirements is just to allow / for {path}
|
@andrerom Is this OK for you ? |
|
Any feedback please ? |
|
+1 The two others are out catching pokemons but should be back next week ;) |
|
+1 |
|
Thanks @lolautruche |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
/layout/setlegacy module throughLegacyKernelControllerhaving a module layout configured, result from legacy kernel is rendered using this module layout.However, when using
/layout/set, you already define a layout in legacy stack (vialayout.ini. Problem is that the result from/layout/setwill be embedded in the configured module layout, which can give veryunexpected results.
Best example is that when you want to render XML, JSON or anything not HTML, you'll have the result embedded in some HTML layout.)
This patch adds
_ezpublishLegacyLayoutSetroute which corresponds to/layout/setmodule, and ensures that if this route is used through legacy kernel, custom layout won't be used.This fixes the usual behavior of layout module.