Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Depend on interfaces in view providers instead of concrete classes #80

Merged
merged 1 commit into from
Feb 10, 2017
Merged

Depend on interfaces in view providers instead of concrete classes #80

merged 1 commit into from
Feb 10, 2017

Conversation

emodric
Copy link
Collaborator

@emodric emodric commented Feb 9, 2017

Backwards compatible change that enables use of these providers with custom View objects.

@emodric
Copy link
Collaborator Author

emodric commented Feb 10, 2017

Ready for merge then? :)

andrerom
andrerom approved these changes Feb 10, 2017
View reviewed changes
Copy link
Contributor

@andrerom andrerom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it is :)

@emodric emodric merged commit 09ac6da into master Feb 10, 2017
@emodric
Copy link
Collaborator Author

emodric commented Feb 10, 2017

Thanks! :)

@emodric emodric deleted the view_provider_interfaces branch February 10, 2017 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdunogier bdunogier bdunogier approved these changes

@andrerom andrerom andrerom approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emodric @bdunogier @andrerom