EZP-27249: Fix routerpass to use defined class #88
Conversation
|
@wizhippo You tested and it works? If so, +1, apart from my comment. |
| @@ -22,6 +23,10 @@ public function process(ContainerBuilder $container) | |||
| return; | |||
| } | |||
|
|
|||
| $container | |||
| ->findDefinition('router.default') | |||
| ->setClass(DefaultRouter::class); | |||
There was a problem hiding this comment.
This should use a FQCN as string, since legacy bridge still supports PHP 5.4.
|
@wizhippo Now I see there's already |
|
@emodric Working here so far. |
| @@ -6,7 +6,6 @@ parameters: | |||
| ezpublish.default_router.legacy_aware_routes: ['_ezpublishLegacyTreeMenu', 'ezpublish_rest_', '_ezpublishPreviewContent', '_wdt', '_profiler', '_assetic'] | |||
|
|
|||
| # Core overrides | |||
| router.class: eZ\Bundle\EzPublishLegacyBundle\Routing\DefaultRouter | |||
| ezpublish.security.login_listener.class: eZ\Bundle\EzPublishLegacyBundle\Security\SecurityListener | |||
| security.authentication.listener.rememberme.class: eZ\Bundle\EzPublishLegacyBundle\Security\RememberMeListener | |||
There was a problem hiding this comment.
if this comes from symfony, then this is broken on 3.x as well.
There was a problem hiding this comment.
Yep. We can fix it in separate PR?
There was a problem hiding this comment.
Are you suggesting another PR just for the parameter removal?
Not quite sure I follow. As the compiler pass now sets the class, this parameter is not used anyway.
Let me know what you want done.
There was a problem hiding this comment.
yes, it can be done in separate PR, just noticed it while reviewing here ;)
|
Thanks @wizhippo 👍 |
Follow kernel and no longer use router.class parameter