Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix watch handling when using API Groups #816

Merged
merged 3 commits into from
Jul 12, 2017

Conversation

jstrachan
Copy link
Contributor

when using API Groups APIs and watches the events come in as Lists rather
than WatchEvent resources so lets handle that gracefully via a helper
method

when using API Groups APIs and watches the events come in as Lists rather than
WatchEvent resources so lets handle that gracefully via a helper method
@iocanel iocanel self-requested a review July 12, 2017 10:07
Copy link
Member

@iocanel iocanel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

When circleci is done, we can merge

@jstrachan jstrachan merged commit 673d02d into fabric8io:master Jul 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants