Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Read Me template patch] Warn about #871 until it's actually fixed. #4497

Merged
merged 1 commit into from
May 22, 2018

Conversation

saimonmoore
Copy link
Contributor

Small docs change to Read Me template:

#871 is still an issue on the latest version of react-scripts (1.1.4 at time of writing).

Rather than having people eventually find this issue and waste time, be more helpful and provide a note in the readme so people are aware this is an issue and don't waste time.

create-react-app is great for people that are learning react and this issue affects them negatively.

This note can be removed once the issue is fixed.

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@gaearon
Copy link
Contributor

gaearon commented May 21, 2018

We have this section.

https://github.com/facebook/create-react-app/blob/master/packages/react-scripts/template/README.md#npm-test-hangs-on-macos-sierra

Its title should probably change to “hangs or crashes”. Then you can link to this section instead of describing the problem again.

@saimonmoore
Copy link
Contributor Author

Ok cool. Thanks @gaearon .

Yes I completely skipped over it because I didn't see a hang. Your suggestion makes sense. I'll update this PR to make that change

@saimonmoore
Copy link
Contributor Author

@gaearon done. Small change but I think it'll go a long way to helping other.s

@@ -2565,7 +2565,7 @@ If this doesn’t happen, try one of the following workarounds:

If none of these solutions help please leave a comment [in this thread](https://github.com/facebook/create-react-app/issues/659).

### `npm test` hangs on macOS Sierra
### `npm test` hangs or crashes on macOS Sierra
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also need to fix the link in table of contents above.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah noticed just after I pushed. Fixed.

@iansu
Copy link
Contributor

iansu commented May 22, 2018

Thanks!

@iansu iansu added this to the 2.0.0 milestone May 23, 2018
zmitry pushed a commit to zmitry/create-react-app that referenced this pull request Sep 30, 2018
@lock lock bot locked and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants