Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Babel 7 🎉 #4932

Closed
wants to merge 1 commit into from
Closed

Conversation

prichodko
Copy link

@prichodko prichodko commented Aug 28, 2018

Babel 7 was officially released! You can read more in a blog post and migration guide.

All beta packages are now updated to 7.0.0 and few Babel related packages like babel-loader and babel-eslint to latest versions.

However I don't understand why here and here are used both babel-core and @babel/core packages. When I was trying to find it out with yarn why I got:

info Reasons this module exists
   - "workspace-aggregator-cae0c8be-8a10-427b-879e-acc933004e45" depends on it
   - Hoisted from "_project_#react-scripts#babel-core"
   - Hoisted from "_project_#react-error-overlay#babel-core"

Last but not least, huge shout out to the whole Babel team and thank you for your hard work.

Edit: Failing test suite not related to changes in this PR.
2nd Edit: I already know what babel-core@7.0.0-bridge does 😆

@zhuangya
Copy link

#4876

@Pajn
Copy link
Contributor

Pajn commented Aug 28, 2018

Could this be released as a new prerelease version of babel-preset-react-app for people using it outside of create-react-app?

@wolfy1339
Copy link

wolfy1339 commented Sep 5, 2018

I have forked babel-preset-react-app and it is compatible with version 7.0.0, simply use @hellomouse/babel-preset-react-app instead

@wolfy1339
Copy link

Is it possible to get this fast-tracked?

@pksunkara
Copy link

Can we please get this merged and released in next? Thanks.

Timer added a commit to Timer/create-react-app that referenced this pull request Sep 19, 2018
@Timer Timer mentioned this pull request Sep 20, 2018
@Timer Timer closed this in #5042 Sep 20, 2018
Timer added a commit that referenced this pull request Sep 20, 2018
@pksunkara
Copy link

@Timer Thanks for the merge. When can we expect the publish?

@prichodko prichodko deleted the chore/babel-7 branch September 20, 2018 14:29
@ajkl2533
Copy link

@Timer thank you, I'm looking forward for releasing this :)

zmitry pushed a commit to zmitry/create-react-app that referenced this pull request Sep 30, 2018
@lock lock bot locked and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants