Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggle mjs files to javascript/auto type #5151

Merged
merged 1 commit into from
Sep 28, 2018
Merged

Conversation

Timer
Copy link
Contributor

@Timer Timer commented Sep 28, 2018

graphql/graphql-js#1272

Wow, this new testing setup is really handy.

@Timer Timer added this to the 2.0.0 milestone Sep 28, 2018
@Timer Timer requested a review from gaearon September 28, 2018 12:19
@Timer
Copy link
Contributor Author

Timer commented Sep 28, 2018

There's an issue up apollographql/apollo-link-state#308 but this is bound to happen more, javascript/auto will be the safest default until we support mjs more robustly.

@Timer
Copy link
Contributor Author

Timer commented Sep 28, 2018

Landing this and releasing.

@Timer Timer merged commit 3ae3cf3 into facebook:master Sep 28, 2018
@Timer Timer deleted the fix-graphql branch September 28, 2018 12:34
zmitry pushed a commit to zmitry/create-react-app that referenced this pull request Sep 30, 2018
@jgoux
Copy link

jgoux commented Oct 2, 2018

Hello,

this is still broken for me.

import graphql, { parse, buildASTSchema, buildClientSchema } from 'graphql'
console.log(graphql, parse, buildASTSchema, buildClientSchema)
// ouput : /static/media/index.497f5ee2.mjs undefined undefined undefined

I'm using react-scripts@2.0.3

edit : Don't you have to exclude the .mjs extension from the file-loader?

@lock lock bot locked and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants