Format SVG React snapshots as <svg> tag with props #5196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmitry
pushed a commit
to zmitry/create-react-app
that referenced
this pull request
Oct 2, 2018
* Format SVG React snapshots as <svg> tag with props * Keep output simpler
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue in #5147 (comment).
We used to just emit filename for SVG snapshots when imported as React components. But that's not super useful and we forgot to change it before the release.
This prints it as an SVG tag instead, with any props passed in. But we don't render the inside.
Before and after:
Closes #5191.