Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avoid TypeError on when registering service workers without config #5301

Merged
merged 2 commits into from
Oct 5, 2018
Merged

avoid TypeError on when registering service workers without config #5301

merged 2 commits into from
Oct 5, 2018

Conversation

peterbe
Copy link

@peterbe peterbe commented Oct 5, 2018

Fixes #5299

I have no idea how to unit test this. Just trying to get the ball rolling.

@peterbe peterbe mentioned this pull request Oct 5, 2018
Closed
@Timer Timer added this to the 2.0.5 milestone Oct 5, 2018
@Timer
Copy link
Contributor

Timer commented Oct 5, 2018

Thanks!

@Timer Timer merged commit e783bf8 into facebook:master Oct 5, 2018
@peterbe peterbe deleted the 5299-avoid-typeerror-on-when-registering-service-workers-without-config branch October 5, 2018 12:16
@Timer Timer mentioned this pull request Oct 9, 2018
Closed
zmitry pushed a commit to zmitry/create-react-app that referenced this pull request Oct 29, 2018
@Timer
avoid TypeError on when registering service workers without config (f…
6d95977 
…acebook#5301)

* avoid TypeError on when registering service workers without config

Fixes facebook#5299

* same before config.onUpdate
@lock lock bot locked and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed tag: bug fix
Projects
None yet
Milestone
2.0.5
Development

Successfully merging this pull request may close these issues.
3 participants
@peterbe @Timer @facebook-github-bot