Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default values to file_ext note #5823

Merged
merged 4 commits into from
Nov 27, 2018
Merged

Add default values to file_ext note #5823

merged 4 commits into from
Nov 27, 2018

Conversation

alaycock
Copy link
Contributor

@alaycock alaycock commented Nov 15, 2018

The docs currently indicate that to enabling sass/scss support alongside flow can be done by adding the following to your .flowconfig.

[options]
module.file_ext=.sass
module.file_ext=.scss

Making that change is insufficient because defining values for module.file_ext overwrite the default values, and will prevent flow from reading from .js files, which prevents flow from functioning as expected.

You also need to add the following values, in order to prevent overwriting the defaults.

module.file_ext=.js
module.file_ext=.jsx
module.file_ext=.mjs
module.file_ext=.json

I would be open documenting this in another way that is less verbose, but I think that there should be some indication that adding those values will overwrite the defaults.

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@EddiG
Copy link

EddiG commented Nov 23, 2018

@alaycock Thanks for the PR! Do you think that explaining it more explicitly and with the link to the documentation of the Flow will be more clear?
I thought about "If you're using Flow, overwrite the module.file_ext in your .flowconfig so it'll recognize the .sass or .scss imports."

@alaycock
Copy link
Contributor Author

Good call @EddiG, I've updated the note.

@iansu iansu added this to the 2.1.2 milestone Nov 27, 2018
@iansu iansu merged commit 5352a0c into facebook:master Nov 27, 2018
@iansu
Copy link
Contributor

iansu commented Nov 27, 2018

Thanks!

@alaycock alaycock deleted the patch-1 branch November 27, 2018 23:12
timsnadden added a commit to timsnadden/create-react-app that referenced this pull request Dec 7, 2018
* master: (39 commits)
  Added extension to .eslintrc (facebook#5988)
  Update links to docs in all package README files (facebook#5912)
  Use https for linked images in docs to fix mixed content warnings (facebook#5985)
  Improve error messaging in verifyPackageTree.js (facebook#5974)
  Add removeItem to localStorage mock in docs (facebook#5919)
  Add SASS_PATH instructions to Sass docs (facebook#5917)
  Suggest a different default for speed reasons (facebook#5959)
  Add pre-eject message about new features in v2 (facebook#5954)
  Add netlify.toml to prepare for deploy to netlify facebook#5807 (facebook#5930)
  Correct some comments (facebook#5927)
  Add note to docs about using Sass and Flow together (facebook#5823)
  Update PWA link in README (facebook#5907)
  Add placeholders to template README for bit.ly links. (facebook#5808)
  Disable copy to clipboard in cra --info (facebook#5905)
  Support setupTests.ts (facebook#5698)
  Remove unnecessary whitespace in template HTML
  Run prettier on HTML files (facebook#5839)
  Some Grammar fixes (facebook#5858)
  Fix link to page about running tests (facebook#5883)
  fix: make typescriptformatter support 0.5 of fork checker (facebook#5879)
  ...
@lock lock bot locked and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants