Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(v2): docs plugin refactor #3245

Merged
merged 32 commits into from
Aug 17, 2020
Merged

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Aug 8, 2020

Motivation

The docs plugin is a bit messy

We should improve so that it's easier to introduce the new versioning features I plan to work on

Test Plan

Existing tests, preview

@slorber slorber requested a review from yangshun as a code owner August 8, 2020 19:50
@slorber slorber added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Aug 8, 2020
@slorber slorber marked this pull request as draft August 8, 2020 19:51
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Aug 8, 2020
@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Aug 8, 2020

Deploy preview for docusaurus-2 ready!

Built with commit a362c08

https://deploy-preview-3245--docusaurus-2.netlify.app

@slorber slorber marked this pull request as ready for review August 14, 2020 14:43
@slorber slorber requested a review from lex111 as a code owner August 14, 2020 14:43
@slorber slorber added the pr: polish This PR adds a very minor behavior improvement that users will enjoy. label Aug 17, 2020
@slorber slorber merged commit a4c8a7f into master Aug 17, 2020
@yangshun yangshun deleted the slorber/docs-plugin-refactor branch August 26, 2020 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading. pr: polish This PR adds a very minor behavior improvement that users will enjoy.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants