Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(theme): support details/summary in CommonMark + add md dogfood test cases #9093

Merged
merged 4 commits into from
Jun 22, 2023

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Jun 22, 2023

Motivation

Having similar tests for md/mdx modes ensure we offer a consistent experience to our users.

Currently, those tests show it's not the case, see problems reported here: #9092

Also add better tests for html comments support, cf edge case bug reported here: #9084

This PR is also a mini fix adding support for summary/details in CommonMark mode, see #9092 (comment)

Test Plan

preview

Test links

https://deploy-preview-9093--docusaurus-2.netlify.app/tests/pages/markdown-tests-md

https://deploy-preview-9093--docusaurus-2.netlify.app/tests/pages/markdown-tests-mdx

Related issues/PRs

@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Jun 22, 2023
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jun 22, 2023
@netlify
Copy link

netlify bot commented Jun 22, 2023

[V2]

Name Link
🔨 Latest commit 3a36285
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/649470f50111350008031c00
😎 Deploy Preview https://deploy-preview-9093--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Jun 22, 2023

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 80 🟢 97 🟢 92 🟢 100 🟠 89 Report
/docs/installation 🟠 74 🟢 100 🟢 92 🟢 100 🟠 89 Report

@github-actions
Copy link

github-actions bot commented Jun 22, 2023

Size Change: 0 B

Total Size: 1.1 MB

ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 117 kB
website/build/assets/css/styles.********.css 113 kB
website/build/assets/js/main.********.js 828 kB
website/build/index.html 41 kB

compressed-size-action

@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Jun 22, 2023
@slorber slorber changed the title docs: add md dogfood test cases: comments, details, tabs, code blocks... fix: support details/summary in CommonMark + add md dogfood test cases Jun 22, 2023
@slorber slorber removed the pr: documentation This PR works on the website or other text documents in the repo. label Jun 22, 2023
@slorber slorber changed the title fix: support details/summary in CommonMark + add md dogfood test cases fix(theme): support details/summary in CommonMark + add md dogfood test cases Jun 22, 2023
@slorber slorber merged commit 3b85f07 into main Jun 22, 2023
@slorber slorber deleted the slorber/more-markdown-tests branch June 22, 2023 16:33
This was referenced Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants