Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Note showLastUpdateTime requires complete checkout #9784

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

mjec
Copy link
Contributor

@mjec mjec commented Jan 24, 2024

Documenting per discussion at #9734

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • N/A If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • N/A If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

This requirement isn't clearly documented, but comes up from time to time (e.g. #9734).

Test Plan

Deploy preview: https://deploy-preview-9784--docusaurus-2.netlify.app/docs/api/plugins/@docusaurus/plugin-content-docs/#showLastUpdateTime (direct link to change)

Test links

N/A

@mjec mjec requested a review from slorber as a code owner January 24, 2024 18:02
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jan 24, 2024
Copy link

netlify bot commented Jan 24, 2024

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit 7737f5c
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/65b150bdd10d730008c7c2f8
😎 Deploy Preview https://deploy-preview-9784--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 57 🟢 98 🟢 100 🟢 100 🟠 89 Report
/docs/installation 🟠 87 🟢 98 🟢 100 🟢 100 🟠 89 Report
/docs/category/getting-started 🟠 75 🟢 100 🟢 100 🟢 90 🟠 89 Report
/blog 🟠 70 🟢 100 🟢 100 🟢 90 🟠 89 Report
/blog/preparing-your-site-for-docusaurus-v3 🟠 64 🟢 97 🟢 100 🟢 100 🟠 89 Report
/blog/tags/release 🟠 71 🟢 100 🟢 100 🟠 80 🟠 89 Report
/blog/tags 🟠 76 🟢 100 🟢 100 🟢 90 🟠 89 Report

@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Jan 24, 2024
@slorber slorber merged commit cce1698 into facebook:main Jan 25, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants