Skip to content

Commit

Permalink
Remove extraneous semicolon from fatal/type/impl/trie.h
Browse files Browse the repository at this point in the history
Summary:
Extraneous semicolons are a code smell and can mask more serious problems. `-Wextra-semi-stmt` finds them.

This diff removes an extraneous semicolon or adjusts a macro so that a semicolon is required after the macro (making it look like a standard function).

This file is drawn from a heavy-hitting list, so fixing this problem will allow *many* other files to take advantage of the safety `-Wextra-semi-stmt` offers.

This should be a low-risk diff: if it compiles, it works.

Reviewed By: meyering

Differential Revision: D51631110

fbshipit-source-id: b639984664d990dbf97d1f366f54449ed98ae9ca
  • Loading branch information
r-barnes authored and facebook-github-bot committed Nov 30, 2023
1 parent 4f4c8cf commit af94326
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion fatal/type/impl/trie.h
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ struct l<Offset, Filter, n<Haystack, IsTerminal, Begin, End, Children...>> {

if (!IsTerminal && size == End - Begin - Offset) {
return false;
};
}

using value_type = typename std::iterator_traits<
typename std::decay<NeedleBegin>::type
Expand Down

0 comments on commit af94326

Please sign in to comment.