Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Examples - Movies thumbnails are not changed on filter #322

Closed
cupofjoakim opened this issue Mar 27, 2015 · 2 comments · May be fixed by bumplzz69/react-native#143
Closed

Examples - Movies thumbnails are not changed on filter #322

cupofjoakim opened this issue Mar 27, 2015 · 2 comments · May be fixed by bumplzz69/react-native#143
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@cupofjoakim
Copy link

When using the filter/search in the examples app, the thumbnail icons aren't correct. After selecting a movie to see the details, the image is however correct. This inconsistency makes the example feel broken, which leads to the framework looking iffy.

screen shot 2015-03-27 at 09 31 49
screen shot 2015-03-27 at 09 32 05
@jparishy jparishy mentioned this issue Mar 27, 2015
Closed
@vjeux
Copy link
Contributor

vjeux commented Mar 27, 2015

cc @a2

vjeux pushed a commit to vjeux/react-native that referenced this issue Apr 13, 2015
Cancel contents animation before setting new contents in RCTNetworkIm…
92fc3f4 
…ageView

Summary:
This is a fix for facebook#322

When setting a new image via the imageURL property, the new image
doesn't always replace the previous one when it is finished downloading
because the image view has a previously instated layer animation
on its contents. This cancels any animation prior to setting the new
contents to fix the issue.
Closes facebook#337
Github Author: Julius Parishy <julius>

Test Plan: Imported from GitHub, without a `Test Plan:` line.
vjeux pushed a commit to vjeux/react-native that referenced this issue Apr 14, 2015
Cancel contents animation before setting new contents in RCTNetworkIm…
7817e8e 
…ageView

Summary:
This is a fix for facebook#322

When setting a new image via the imageURL property, the new image
doesn't always replace the previous one when it is finished downloading
because the image view has a previously instated layer animation
on its contents. This cancels any animation prior to setting the new
contents to fix the issue.
Closes facebook#337
Github Author: Julius Parishy <julius>

Test Plan: Imported from GitHub, without a `Test Plan:` line.
vjeux pushed a commit to vjeux/react-native that referenced this issue Apr 15, 2015
Cancel contents animation before setting new contents in RCTNetworkIm…
7bcb467 
…ageView

Summary:
This is a fix for facebook#322

When setting a new image via the imageURL property, the new image
doesn't always replace the previous one when it is finished downloading
because the image view has a previously instated layer animation
on its contents. This cancels any animation prior to setting the new
contents to fix the issue.
Closes facebook#337
Github Author: Julius Parishy <julius>

Test Plan: Imported from GitHub, without a `Test Plan:` line.
@brentvatne
Copy link
Collaborator

Dup of #89

@facebook facebook locked as resolved and limited conversation to collaborators May 31, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Snyk] Fix for 1 vulnerabilities bumplzz69/react-native
4 participants
@brentvatne @vjeux @cupofjoakim @react-native-bot