Red Box should open PyCharm at line number of error #11275
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a simple one line change. When a redbox is launching the editor, if `launchEditor.js` is aware of your editor it can also add a line number to open the file at. So if the stacktrace shows an error on like 56 in `ako.js` then it'll try`wstorm /Users/somelady/src/project/ako.js:56` instead of `wstorm /Users/somelady/src/project/ako.js`. This adds PyCharm's command line launcher, which is named `charm`. There is existing logic to handle other JetBrains editors, so I just did a simple one line addition.
|
By analyzing the blame information on this pull request, we identified @matthewwithanm and @PatoBeltran to be potential reviewers. |
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions. |
ericpalakovichcarr
changed the title
facebook-github-bot
added
the
CLA Signed
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
@facebook-github-bot shipit |
facebook-github-bot
added
the
Import Started
|
@javache has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
mkonicek
pushed a commit
that referenced
this pull request
Dec 12, 2016
Summary: This is a simple one line change. When a red box is launching the editor, if `launchEditor.js` is aware of your editor it can also add a line number to open the file at. So if the stacktrace shows an error on like 56 in `ako.js` then it'll try`wstorm /Users/somelady/src/project/ako.js:56` instead of `wstorm /Users/somelady/src/project/ako.js`. This adds PyCharm's command line launcher, which is named `charm`. There is existing logic to handle other JetBrains editors, so I just did a simple one line addition. **Test plan (required)** * Install PyCharm (if needed) * Set environment variable `REACT_EDITOR` to `charm` * Open PyCharm * Add/replace the current `charm` command via `Tools -> Create Command-line launcher...` in PyCharm. * Run a React Native project with an error in the source code. * In the generated red box, click on one of the entries in the stack trace * File should open in PyCharm at the correct line number. Closes #11275 Differential Revision: D4295724 Pulled By: javache fbshipit-source-id: 29dec525f76c2f0a3ee203cac67408eecc8ac6b6
DanielMSchmidt
pushed a commit
to DanielMSchmidt/react-native
that referenced
this pull request
Jan 4, 2017
Summary: This is a simple one line change. When a red box is launching the editor, if `launchEditor.js` is aware of your editor it can also add a line number to open the file at. So if the stacktrace shows an error on like 56 in `ako.js` then it'll try`wstorm /Users/somelady/src/project/ako.js:56` instead of `wstorm /Users/somelady/src/project/ako.js`. This adds PyCharm's command line launcher, which is named `charm`. There is existing logic to handle other JetBrains editors, so I just did a simple one line addition. **Test plan (required)** * Install PyCharm (if needed) * Set environment variable `REACT_EDITOR` to `charm` * Open PyCharm * Add/replace the current `charm` command via `Tools -> Create Command-line launcher...` in PyCharm. * Run a React Native project with an error in the source code. * In the generated red box, click on one of the entries in the stack trace * File should open in PyCharm at the correct line number. Closes facebook#11275 Differential Revision: D4295724 Pulled By: javache fbshipit-source-id: 29dec525f76c2f0a3ee203cac67408eecc8ac6b6
grabbou
pushed a commit
to react-native-community/cli
that referenced
this pull request
Sep 26, 2018
Summary: This is a simple one line change. When a red box is launching the editor, if `launchEditor.js` is aware of your editor it can also add a line number to open the file at. So if the stacktrace shows an error on like 56 in `ako.js` then it'll try`wstorm /Users/somelady/src/project/ako.js:56` instead of `wstorm /Users/somelady/src/project/ako.js`. This adds PyCharm's command line launcher, which is named `charm`. There is existing logic to handle other JetBrains editors, so I just did a simple one line addition. **Test plan (required)** * Install PyCharm (if needed) * Set environment variable `REACT_EDITOR` to `charm` * Open PyCharm * Add/replace the current `charm` command via `Tools -> Create Command-line launcher...` in PyCharm. * Run a React Native project with an error in the source code. * In the generated red box, click on one of the entries in the stack trace * File should open in PyCharm at the correct line number. Closes facebook/react-native#11275 Differential Revision: D4295724 Pulled By: javache fbshipit-source-id: 29dec525f76c2f0a3ee203cac67408eecc8ac6b6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simple one line change. When a red box is launching the editor, if
launchEditor.jsis aware of your editor it can also add a line number to open the file at. So if the stacktrace shows an error on like 56 inako.jsthen it'll trywstorm /Users/somelady/src/project/ako.js:56instead ofwstorm /Users/somelady/src/project/ako.js.This adds PyCharm's command line launcher, which is named
charm. There is existing logic to handle other JetBrains editors, so I just did a simple one line addition.Test plan (required)
REACT_EDITORtocharmcharmcommand viaTools -> Create Command-line launcher...in PyCharm.