Add perspective transform support on Android #11713
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @kmagiera and @janicduplessis to be potential reviewers. |
facebook-github-bot
added
GH Review: review-needed
CLA Signed
|
awesome |
|
Any news on this being merged? Know you guys probably get swamped with requests but this would be awesome |
|
@facebook-github-bot shipit |
|
@brentvatne has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
edmofro
pushed a commit
to edmofro/react-native
that referenced
this pull request
Feb 6, 2017
Summary: Rebased facebook#6926 against master. Fixes facebook#2915 Closes facebook#11713 Differential Revision: D4513111 fbshipit-source-id: 9fb653c4bfd64eda12a605f6cabb0159b2af8f73
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 7, 2017
Summary: Rebased facebook#6926 against master. Fixes facebook#2915 Closes facebook#11713 Differential Revision: D4513111 fbshipit-source-id: 9fb653c4bfd64eda12a605f6cabb0159b2af8f73
rozele
pushed a commit
to microsoft/react-native-windows
that referenced
this pull request
Feb 8, 2017
Summary: Rebased #6926 against master. Fixes #2915 Closes facebook/react-native#11713 Differential Revision: D4513111 fbshipit-source-id: 9fb653c4bfd64eda12a605f6cabb0159b2af8f73
normanjoyner
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: Rebased facebook#6926 against master. Fixes facebook#2915 Closes facebook#11713 Differential Revision: D4513111 fbshipit-source-id: 9fb653c4bfd64eda12a605f6cabb0159b2af8f73
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: Rebased facebook#6926 against master. Fixes facebook#2915 Closes facebook#11713 Differential Revision: D4513111 fbshipit-source-id: 9fb653c4bfd64eda12a605f6cabb0159b2af8f73
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: Rebased facebook#6926 against master. Fixes facebook#2915 Closes facebook#11713 Differential Revision: D4513111 fbshipit-source-id: 9fb653c4bfd64eda12a605f6cabb0159b2af8f73
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: Rebased facebook#6926 against master. Fixes facebook#2915 Closes facebook#11713 Differential Revision: D4513111 fbshipit-source-id: 9fb653c4bfd64eda12a605f6cabb0159b2af8f73
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: Rebased facebook#6926 against master. Fixes facebook#2915 Closes facebook#11713 Differential Revision: D4513111 fbshipit-source-id: 9fb653c4bfd64eda12a605f6cabb0159b2af8f73
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: Rebased facebook#6926 against master. Fixes facebook#2915 Closes facebook#11713 Differential Revision: D4513111 fbshipit-source-id: 9fb653c4bfd64eda12a605f6cabb0159b2af8f73
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: Rebased facebook#6926 against master. Fixes facebook#2915 Closes facebook#11713 Differential Revision: D4513111 fbshipit-source-id: 9fb653c4bfd64eda12a605f6cabb0159b2af8f73
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: Rebased facebook#6926 against master. Fixes facebook#2915 Closes facebook#11713 Differential Revision: D4513111 fbshipit-source-id: 9fb653c4bfd64eda12a605f6cabb0159b2af8f73
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: Rebased facebook#6926 against master. Fixes facebook#2915 Closes facebook#11713 Differential Revision: D4513111 fbshipit-source-id: 9fb653c4bfd64eda12a605f6cabb0159b2af8f73
GaborWnuk
pushed a commit
to GaborWnuk/react-native
that referenced
this pull request
Feb 28, 2017
Summary: Rebased facebook#6926 against master. Fixes facebook#2915 Closes facebook#11713 Differential Revision: D4513111 fbshipit-source-id: 9fb653c4bfd64eda12a605f6cabb0159b2af8f73
maarf
pushed a commit
to fullcontact/react-native
that referenced
this pull request
Apr 26, 2017
Summary: Rebased facebook#6926 against master. Fixes facebook#2915 Closes facebook#11713 Differential Revision: D4513111 fbshipit-source-id: 9fb653c4bfd64eda12a605f6cabb0159b2af8f73
wcandillon
reviewed
Nov 13, 2018
| @@ -165,6 +166,22 @@ private static void setTransformProperty(View view, ReadableArray transforms) { | |||
| view.setRotationY((float) sMatrixDecompositionContext.rotationDegrees[1]); | |||
| view.setScaleX((float) sMatrixDecompositionContext.scale[0]); | |||
| view.setScaleY((float) sMatrixDecompositionContext.scale[1]); | |||
|
|
|||
| double[] perspectiveArray = sMatrixDecompositionContext.perspective; | |||
|
|
|||
There was a problem hiding this comment.
When no perspective is set, on Android, you still see some perspective when doing "3d transformation" while on iOS it show as expected. Therefore you always get a different result on iOS and Android when setting perspective yourself. Do you see what I mean? I could provide some examples.
I would like to know what is the default perspective an android so I can adjust the transformation correctly for android.
Thank you so much for your great work, really appreciate it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased #6926 against master.
Fixes #2915
Test plan:
Check that the perspective of the flip card in UIExplorer is same on both iOS and Android
cc @kevinstumpf @brentvatne @lexs