TabBarIOS tintColor #1337
TabBarIOS tintColor #1337
Conversation
facebook-github-bot
added
the
CLA Signed
|
Lucky number 1337! Can you expand upon the tab bar example code to show this new functionality? |
|
@ericvicenti do you know how launch UIExplorer e2e test directly on my desktop ? I tried some commands cd Examples/UIExplorer
xctool -scheme UIExplorer -sdk iphonesimulator8.1./scripts/e2e-test.sh./runXcodeTests.shBut I can't reproduce the failing test I have to retrieve the new screenshot and put it on the xamples/UIExplorer/UIExplorerTests/ReferenceImages/Examples-UIExplorer-UIExplorerApp/ folder, but I can't launch the test. Anyone knows ? |
|
Ah, so the snapshot tests can be finicky. Things will look different based on the device in the simulator, 32 vs 64 bit, OS version, etc. Are you re-recording the snapshot on iPhone 5 (32-bit) and iOS 8.x? You should be able to run the tests locally with |
Yeah, I record the snapshot with iOS 8.1 and iPhone 5 but I can't specify 32-bit. The difference between my screenshot and the oldest, its the text size, mine is more smaller than the oldest. @ericvicenti Do you know why ? |
|
@ericvicenti it's ok ? I changed the “recordMode” from NO to YES inside the UIExplorerTests, the “reference image” has been updated, and I can’t see my changes on the screenshot, but I see the changes when I run the UIExplorer project on Xcode, do you know why ? And by now, the tests pass but it is bullshit according to me. What is the next steps to merge this feature ? |
|
@nicklockwood Do you have something to add ? |
|
Running tests on iPhone 5 automatically makes them 32-bit, iPhone 5s and above is 64-bit. I don't know why you wouldn't be seeing the changes in the reference image. That's very strange. |
| @@ -89,6 +91,9 @@ var TabBarExample = React.createClass({ | |||
| }); | |||
|
|
|||
| var styles = StyleSheet.create({ | |||
| tabBar: { | |||
|
@nicklockwood code updated ;-) Can you try this branch if you see the tab bar in blue on the UIExplorer project ? |
|
@a2 @nicklockwood @ericvicenti merging is possible ? |
|
This would be nice to get merged! :) |
|
Looks good to me |
|
@brentvatne what is the next step ? This could be merged friday during the time afforded to those things ? -> https://gist.github.com/brentvatne/e1ca1e4beaf0135e3178 |
|
This was actually merged yesterday. Should be included in the next update. Sorry for the wait! |
|
👍 thanks @nicklockwood! |
|
@tsunammis - looks like that won't be needed 😄 hope you join in on Friday! |
|
@brentvatne thank you !! I hope I will be available friday, what is the timezone ? I'm in Paris. |
Summary: [Origin Pull request](facebook#961) from [cmcewen](https://github.com/cmcewen) All the work have been done by @cmcewen, I just rebased his work with the master. Closes facebook#1337 Github Author: Stan Chollet <stanislas.chollet@gmail.com> Test Plan: Imported from GitHub, without a `Test Plan:` line.
|
@tsunammis - I'll be around at 10am - 3pm PT 😄 |
* Add linting for insensitive and inconsiderate language * Add .alexrc.js * Update alex rules * Minor updates to formatting * Fix deploy_website job name * Update alex rules * Add lintv and .alexignore * Fix lint issues
* Delete more stuff * Remove some stale looking SDX platform scripts * Remove remnant of `acceptsKeyboardFocus` * Add back some missing newlines
Origin Pull request from cmcewen
All the work have been done by @cmcewen, I just rebased his work with the master.