[Navigator] Support the ref prop on scene roots
#1361
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Navigator overrides the `ref` prop of scene components so that it can call `onItemRef` and do internal bookkeeping. With callback refs, we can additionally call the original value of the `ref` prop as long as it's a function (that is, string refs are not supported). Note that the `ref` prop is moved to `reactElement.ref` out of `reactElement.props.ref`, which is why this diff accesses `child.ref`. This diff adds support for callback refs and warns helpfully if a string ref was provided. It should be completely backwards compatible since scenes couldn't have been relying on the `ref` prop before.
facebook-github-bot
added
the
CLA Signed
|
Brilliant! This is why function refs are so much better. Thanks for fixing this, @ide @facebook-github-bot import |
|
Thanks for importing. If you are an FB employee go to https://our.intern.facebook.com/intern/opensource/github/pull_request/1663226797244458/int_phab to review. |
|
Nice. |
ayushjainrksh
pushed a commit
to MLH-Fellowship/react-native
that referenced
this pull request
Jul 2, 2020
facebook#1361) * Replace current 14 'showcase' brands to scaled images (68x68) * Resize the 14 images to be '100x100' instead of '68x68' * perf: Optimize 14 showcase images (200x200) * file: Add 200x200 'artsy' optimized logo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Navigator overrides the
refprop of scene components so that it can callonItemRefand do internal bookkeeping. With callback refs, we can additionally call the original value of therefprop as long as it's a function (that is, string refs are not supported). Note that therefprop is moved toreactElement.refout ofreactElement.props.ref, which is why this diff accesseschild.ref.This diff adds support for callback refs and warns helpfully if a string ref was provided. It should be completely backwards compatible since scenes couldn't have been relying on the
refprop before.cc @ericvicenti
Test Plan: Write a renderScene implementation that puts a callback ref on the root component: