Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TextInput] Update placeholder style prop #1414

Closed
wants to merge 16 commits into from
Closed

[TextInput] Update placeholder style prop #1414

wants to merge 16 commits into from

Conversation

bimawa
Copy link
Contributor

@bimawa bimawa commented May 26, 2015

@facebook-github-bot facebook-github-bot added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels May 26, 2015
@ide
Copy link
Contributor

ide commented May 28, 2015

API feedback - how about placeholderStyle={{fontSize: 10, fontFamily: 'Comic Sans'}}?

@bimawa
Copy link
Contributor Author

bimawa commented May 28, 2015

hmm Cool idea i try it later. thx @ide. But i thing its may confuses a bit?

@bimawa
Copy link
Contributor Author

bimawa commented May 28, 2015

@ide cat u help me? Where i can found parse styles of component, for adding placeholderStyle to same logic?

@brentvatne brentvatne changed the title Update TextInput Attribute [TextInput] Update placeholder style prop May 30, 2015
sahrens
sahrens reviewed Jun 11, 2015
View reviewed changes
Examples/UIExplorer/UIExplorer/AppDelegate.m
@@ -36,7 +36,7 @@ - (BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:(
* on the same Wi-Fi network.
*/

jsCodeLocation = [NSURL URLWithString:@"http://localhost:8081/Examples/UIExplorer/UIExplorerApp.includeRequire.runModule.bundle?dev=true"];
jsCodeLocation = [NSURL URLWithString:@"http://bimawa.local:8081/Examples/UIExplorer/UIExplorerApp.includeRequire.runModule.bundle?dev=true"];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please don't change this - it looks like you have several commits stacked in this PR - can you move the unrelated ones to new PR's and squash the remaining ones into one commit for this PR?

@sahrens sahrens self-assigned this Jun 11, 2015
@sahrens
Copy link
Contributor

sahrens commented Jun 11, 2015

Can you move this out of core style stuff and just make it a plain prop with the API @ide suggested? Also, can you add to the TextInput Example?

@bimawa
Copy link
Contributor Author

bimawa commented Jun 12, 2015

@sahrens damn it's my bad, this commit 93a4bb8 was for research.. i revoke this pull request later.

Can you move this out of core style stuff and just make it a plain prop

now i research how make style parser for create like suggest @vjeux
<TextInput placeholderText="abc..." placeholderStyle={{ color: 'red' }} />

Also, can you add to the TextInput Example?

i made changes in UIExplorer example for test in search TextInput field. Examples/UIExplorer/UIExplorerList.js

@bimawa bimawa closed this Jul 5, 2015
@bimawa bimawa deleted the develop branch July 5, 2015 09:54
ayushjainrksh pushed a commit to MLH-Fellowship/react-native that referenced this pull request Jul 2, 2020
@thozh @charpeni
Update hermes.md (facebook#1414)
861a3a8 
always returning false even if enabledHermes is set to true.

the change correctly return if hermes is enabled
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sahrens sahrens

Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bimawa @ide @sahrens @facebook-github-bot