[CI] Migrate to Circle 2.0 #14955
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,101 @@ | ||
| aliases: | ||
| - &restore-cache | ||
| keys: | ||
| - dependencies-{{ .Branch }}-{{ checksum "package.json" }} | ||
| # Fallback in case checksum fails | ||
| - dependencies-{{ .Branch }}- | ||
| - &save-cache | ||
| paths: | ||
| - node_modules | ||
| key: dependencies-{{ .Branch }}-{{ checksum "package.json" }} | ||
|
|
||
| - &restore-cache-website | ||
| keys: | ||
| - website-dependencies-{{ .Branch }}-{{ checksum "website/package.json" }} | ||
| # Fallback in case checksum fails | ||
| - website-dependencies-{{ .Branch }}- | ||
| - &save-cache-website | ||
| paths: | ||
| - website/node_modules | ||
| key: website-dependencies-{{ .Branch }}-{{ checksum "website/package.json" }} | ||
|
|
||
| - &restore-cache-danger | ||
| keys: | ||
| - danger-dependencies-{{ .Branch }}-{{ checksum "danger/package.json" }} | ||
| # Fallback in case checksum fails | ||
| - danger-dependencies-{{ .Branch }}- | ||
| - &save-cache-danger | ||
| paths: | ||
| - danger/node_modules | ||
| key: danger-dependencies-{{ .Branch }}-{{ checksum "danger/package.json" }} | ||
|
|
||
| - &restore-cache-android | ||
| keys: | ||
| - android-dependencies-{{ .Branch }}-{{ checksum "ReactAndroid/build.gradle" }} | ||
| # Fallback in case checksum fails | ||
| - android-dependencies-{{ .Branch }}- | ||
| - &save-cache-android | ||
| paths: | ||
| - "ReactAndroid/build/downloads" | ||
| key: android-dependencies-{{ .Branch }}-{{ checksum "ReactAndroid/build.gradle" }} | ||
|
|
||
| - &restore-cache-buck | ||
| keys: | ||
| # TODO: Pick file to checksum against | ||
|
There was a problem hiding this comment. I just realized with CircleCI caching we'd stop using the latest copy of Buck. If we want that, one thing we could do is commit a small file to RN that contains just a Git commit hash or Git tag of the Buck repo. We'd check out just that commit and cache it. That way we intentionally don't use the latest copy of Buck and also consistently use the same version, not at the whim of CircleCI's caching behavior. If we do want to use the latest copy of Buck, we could create a shallow clone of its Git repo (to avoid downloading 500MB) and build it each time. |
||
| - buck-dependencies-{{ .Branch }} | ||
| - &save-cache-buck | ||
| paths: | ||
| - "/home/ubuntu/buck" | ||
| key: buck-dependencies-{{ .Branch }} | ||
|
|
||
|
|
||
| version: 2 | ||
| jobs: | ||
| test-node-8: | ||
| working_directory: ~/react-native | ||
| docker: | ||
| - image: circleci/node:8.1.4 | ||
|
There was a problem hiding this comment. What do you think of just making this be |
||
| steps: | ||
| - checkout | ||
| - restore-cache: *restore-cache | ||
| - npm install | ||
|
There was a problem hiding this comment. Need this to be behind the |
||
| - save-cache: *save-cache | ||
| - run: | | ||
| npm run lint | ||
| npm run flow -- check | ||
| npm test -- --maxWorkers=1 | ||
| test-node-6: | ||
| working_directory: ~/react-native | ||
| docker: | ||
| - image: circleci/node:6.11.0 | ||
| steps: | ||
| - checkout | ||
| - restore-cache: *restore-cache | ||
| - npm install | ||
| - save-cache: *save-cache | ||
| - run: | | ||
| npm run lint | ||
| npm run flow -- check | ||
| npm test -- --maxWorkers=1 | ||
| test-node-4: | ||
| working_directory: ~/jest | ||
|
There was a problem hiding this comment. Should this be ~/react-native like the others? There was a problem hiding this comment. It should! I followed Jest's as a starting point, and I overlooked this line. |
||
| docker: | ||
| - image: circleci/node:4.8.4 | ||
| steps: | ||
| - checkout | ||
| - restore-cache: *restore-cache | ||
| - npm install | ||
| - save-cache: *save-cache | ||
| - run: | | ||
| npm run lint | ||
| npm run flow -- check | ||
| npm test -- --maxWorkers=1 | ||
|
|
||
| # Workflows enables us to run multiple jobs in parallel | ||
| workflows: | ||
| version: 2 | ||
| build-and-deploy: | ||
| jobs: | ||
| - test-node-8 | ||
| - test-node-6 | ||
| - test-node-4 | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you prefix all the keys with
v1-so we can easily manually bust the cache if we need to?I'm also concerned about sharing node_modules caches across npm versions. In particular, Node 4 comes with npm 2 which doesn't have the deduping functionality of npm 3+.
What if we didn't cache node_modules for react-native but continued to cache them for the website and danger (where we use just a single Node + npm version)?