[iOS] Fix TextInput numeric keyboard submit

[gontovnik]

When you have a numeric non-multiline TextInput and a returnKeyType is done we automatically add an input accessory view (implementation).

That view has a done button which triggers handleInputAccessoryDoneButton which currently directly sends endEditing: to the text field / text view. As a consequence, the textInputShouldReturn is not called and we dismiss the keyboard even if the blurOnSubmit value is false.

Test Plan

Confirm that the keyboard is not dismissed when you tap on Done button on this TextInput:

<TextInput
  keyboardType={'numeric'}
  returnKeyType={'done'}
  blurOnSubmit={false}
/>

and that the keyboard is dismissed for this TextInput:

<TextInput
  keyboardType={'numeric'}
  returnKeyType={'done'}
  blurOnSubmit
/>

[pull-bot]

Attention: @shergin

Generated by 🚫 dangerJS

[shergin]

@gontovnik Just curious, what the point to have a Done button which does nothing?

[gontovnik]

@shergin, for my specific case, when user presses Done I do some loading and data validation, but I do not want to automatically dismiss the keyboard and then focus on the field again if the entered data is incorrect.

I do not see the reason why the behavior of blurOnSubmit should be different for the numeric and non-numeric keyboard.

[facebook-github-bot]

@javache has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[shergin]

@gontovnik Yes, I absolutely agree with thesis that "Done" button above numeric pad must work same way as "Done" key in regular keyboard. (And it must generate same set of events.)
So, with this diff, in your case, you are able receive a some event, right? Which one?