Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli] Add missing node-notifier npm dependency #15905

Closed
wants to merge 1 commit into from

Conversation

ide
Copy link
Contributor

@ide ide commented Sep 12, 2017

local-cli now depends on the node-notifier package but it wasn't listed in package.json.

Test Plan: Run TravisCI e2e-objc test and see that it is able to launch the CLI successfully.

local-cli now depends on the node-notifier package but it wasn't listed in package.json.

Test Plan: Run TravisCI e2e-objc test and see that it is able to launch the CLI successfully.
@ide ide requested a review from hramos as a code owner September 12, 2017 10:16
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. GH Review: review-needed labels Sep 12, 2017
@pull-bot
Copy link

Warnings
⚠️

🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.

@facebook-github-bot label Core Team

Attention: @hramos

Generated by 🚫 dangerJS

@facebook-github-bot facebook-github-bot added the Import Started This pull request has been imported. This does not imply the PR has been approved. label Sep 12, 2017
@facebook-github-bot
Copy link
Contributor

@hramos has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@elicwhite
Copy link
Member

@ide, thanks for the fix.

@hramos, how was this problem able to land and pass our internal build?

@hramos
Copy link
Contributor

hramos commented Sep 21, 2017

I'm not sure I follow. When was the dependency added? Was it in an internal commit or through an external PR?

@rigdern
Copy link
Contributor

rigdern commented Sep 21, 2017

@hramos git log -S node-notifier shows that commit c88b2b2 introduced code which uses node-notifier. I don't see a PR associated with this commit so I'm guessing it was an internal commit.

@ide ide deleted the node-notifier-dep branch September 28, 2017 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Import Started This pull request has been imported. This does not imply the PR has been approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants